Attachment 55584 Details for Bug 17299 – Bug 17299: Display date due correctly on SCO

[patch] Bug 17299: Display date due correctly on SCO

Bug-17299-Display-date-due-correctly-on-SCO.patch (text/plain), 1.50 KB, created by Kyle M Hall (khall) on 2016-09-15 13:23:24 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Kyle M Hall (khall)

Created: 2016-09-15 13:23:24 UTC

Size: 1.50 KB

patch

obsolete

>From 386f7ae9af012c4cb13a87f686915fc95d65585c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 14 Sep 2016 13:25:58 +0100
>Subject: [PATCH] Bug 17299: Display date due correctly on SCO
>
>Unless it's an hourly loan, date due should not display the time part
>(23:59).
>Because of bad code in GetPendingIssues, date_due is replaced with a
>DateTime object and is copied into date_due_sql.
>We need to use this date_due_sql to correctly display the date due in
>the sco module.
>
>Test plan:
>1/ Enable WebBasedSelfCheck syspref
>2/ Check out an item to User A -- Do not use an hourly loan.
>3/ Log in to Koha self check ( {OPAC URL}/cgi-bin/koha/sco/sco-main.pl).
>4/ Enter User A's cardnumber.
>Without this patch, checkouts are
>   MM/DD/YYYY 12:00 AM (Timeformat: 12 hour)
>or MM/DD/YYYY 00:00    (Timeformat: 24H)
>With this patch applied, only the date is displayed
>
>Followed test plan, works as expected.
>Signed-off-by: Marc <veron@veron.ch>
>
>Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com>
>---
> opac/sco/sco-main.pl | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/opac/sco/sco-main.pl b/opac/sco/sco-main.pl
>index 0e2a1b9..c97280b 100755
>--- a/opac/sco/sco-main.pl
>+++ b/opac/sco/sco-main.pl
>@@ -234,6 +234,7 @@ if ($borrower->{cardnumber}) {
>             C4::Context->preference("AllowItemsOnHoldCheckout")
>         );
>         $it->{'norenew'} = 1 if $renewokay->{'NO_MORE_RENEWALS'};
>+        $it->{date_due}  = $it->{date_due_sql};
>         push @issues, $it;
>     }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17299: 55553 | 55563 | 55584