Attachment 55605 Details for Bug 17282 – Bug 17282: (follow-up) Use drop-down menu for download chart instead

[patch] Bug 17282: (follow-up) Use drop-down menu for download chart instead

Bug-17282-follow-up-Use-drop-down-menu-for-downloa.patch (text/plain), 2.25 KB, created by Josef Moravec on 2016-09-16 09:05:30 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2016-09-16 09:05:30 UTC

Size: 2.25 KB

patch

obsolete

>From c65c2c1dd995027e978e801aa28f225573aa0a43 Mon Sep 17 00:00:00 2001
>From: Hector Castro <hector.hecaxmmx@gmail.com>
>Date: Fri, 9 Sep 2016 09:30:37 -0600
>Subject: [PATCH] Bug 17282: (follow-up) Use drop-down menu for download chart
> instead
>
>To Test
>1) Execute a report
>2) Click in drop-down menu "Download" shows only three options
>3) Draw a chart
>4) Click again in drop-down menu "Download" shows a new option "Download chart"
>
>Signed-off-by: Alex Arnaud <alex.arnaud@biblibre.com>
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc           | 1 -
> koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc | 3 +++
> 2 files changed, 3 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>index 0afe847..00b68c1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>@@ -75,6 +75,5 @@
>             </div>
>         </fieldset>
>     </form>
>-    <a id="download-chart" href="#">Download</a>
>     <div id="chart"></div>
> </div>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>index 232ddd3..e1b2b66 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/reports-toolbar.inc
>@@ -53,6 +53,9 @@
>                     <li><a id="csv" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&amp;format=csv&amp;sql=[% sql |uri %]&amp;reportname=[% name |uri %]">Comma separated text</a></li>
>                     <li><a id="tab" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&amp;format=tab&amp;sql=[% sql |uri %]&amp;reportname=[% name |uri %]">Tab separated text</a></li>
>                     <li><a id="ods" href="/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Export&amp;format=ods&amp;sql=[% sql |uri %]&amp;reportname=[% name |uri %]">Open Document Spreadsheet</a></li>
>+            [% IF (results.json) %]
>+                <li><a id="download-chart" href="#">Download chart</a></li>
>+            [% END %]
>                 </ul>
>             </div>
>         [% END %]
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17282: 55412 | 55442 | 55444 | 55480 | 55582 | 55586 | 55588 | 55604 | 55605 | 55606 | 55607 | 55868 | 55869 | 62529 | 63565 | 63566 | 63567 | 63568 | 63569 | 63570 | 63571 | 67225 | 67226 | 67227 | 67228 | 67229 | 67230 | 67231 | 69174 | 69429 | 69430 | 69493 | 79182 | 79230 | 79308 | 79309 | 79310 | 79311 | 79312 | 79313 | 79337 | 79338 | 79339