Attachment 55641 Details for Bug 9896 – [PASSED QA] Bug 9896 - Show vendor in subscription search when creating an order for a subscription

[patch] [PASSED QA] Bug 9896 - Show vendor in subscription search when creating an order for a subscription

PASSED-QA-Bug-9896---Show-vendor-in-subscription-s.patch (text/plain), 3.26 KB, created by Katrin Fischer on 2016-09-18 09:45:19 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-09-18 09:45:19 UTC

Size: 3.26 KB

patch

obsolete

>From 17c408ef91566f37ffbc3faed760d86746d55450 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <arouss1980@gmail.com>
>Date: Tue, 13 Sep 2016 17:41:16 +0300
>Subject: [PATCH] [PASSED QA] Bug 9896 - Show vendor in subscription search
> when creating an order for a subscription
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In the staff client, when creating an order from a subscription
>the vendor name should be shown in a separate column.
>
>This patch adds that feature. The 'Vendor' column is added before
>the 'Library' column since they appear in that order in Advanced
>search.
>
>Test plan:
>0) [PREREQUISITES] In the Staff client, under Acquisitions, create
>   a Vendor and associated Basket if you don't already have them.
>   Then, under Serials, add a new Subscription using the Vendor
>   you've just created.
>1) Go to Acquisitions, and under 'Manage orders' search for a vendor,
>   then click on 'Add to basket' and select 'From a subscription'.
>2) Click 'Search' on the left hand side to search for all subscriptions.
>   Notice how there is no 'Vendor' column in the results table.
>3) Apply the patch.
>4) Repeat step 2. Confirm that the patch works, i.e. there is now
>   a 'Vendor' column which displays the vendor name.
>
>Followed test plan, works as expected.
>
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
>---
> C4/Serials.pm                                                         | 1 +
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt | 4 ++++
> 2 files changed, 5 insertions(+)
>
>diff --git a/C4/Serials.pm b/C4/Serials.pm
>index 3c76cd8..543b1dc 100644
>--- a/C4/Serials.pm
>+++ b/C4/Serials.pm
>@@ -553,6 +553,7 @@ sub SearchSubscriptions {
>             biblio.title,
>             biblio.author,
>             biblio.biblionumber,
>+            aqbooksellers.name AS vendorname,
>             biblioitems.issn
>         FROM subscription
>             LEFT JOIN subscriptionhistory USING(subscriptionid)
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
>index f68d361..b97b20a 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersubscription.tt
>@@ -60,6 +60,7 @@
>                                 <th>ISSN</th>
>                                 <th class="anti-the">Title</th>
>                                 <th> Notes </th>
>+                                <th>Vendor</th>
>                                 <th>Library</th>
>                                 <th>Call number</th>
>                                 <th class="title-string">Expiration date</th>
>@@ -78,6 +79,9 @@
>                                     [% IF (sub.internalnotes) %]([% sub.internalnotes %])[% END %]
>                                 </td>
>                                 <td>
>+                                    [% IF (sub.vendorname) %][% sub.vendorname %][% END %]
>+                                </td>
>+                                <td>
>                                     [% IF (sub.branchcode) %][% Branches.GetName( sub.branchcode ) %][% END %]
>                                 </td>
>                                 <td>
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 9896: 55539 | 55622 | 55624 | 55641