Attachment 55643 Details for Bug 17308 – [PASSED QA] Bug 17308 - 'New patron attribute type' button does not work

[patch] [PASSED QA] Bug 17308 - 'New patron attribute type' button does not work

PASSED-QA-Bug-17308---New-patron-attribute-type-bu.patch (text/plain), 1.73 KB, created by Katrin Fischer on 2016-09-18 10:05:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-09-18 10:05:52 UTC

Size: 1.73 KB

patch

obsolete

>From 738020908a8f72ae68c203ca3b73b36248d110c9 Mon Sep 17 00:00:00 2001
>From: Andreas Roussos <arouss1980@gmail.com>
>Date: Fri, 16 Sep 2016 21:01:58 +0300
>Subject: [PATCH] [PASSED QA] Bug 17308 - 'New patron attribute type' button
> does not work
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>In the Staff client, the 'New patron attribute type' button in the Patron
>attribute types page does not work. This patch fixes that.
>
>Test plan:
>1) In the Staff client, go to Home > Administration > Patron attribute types,
>   and click on the 'New patron attribute type' button. You cannot create a
>   new patron attribute type and you get the following Software error:
>   Not a HASH reference at [...]
>2) Apply the patch.
>3) Repeat step 1). The 'New patron attribute type' button now works.
>
>Followed test plan, works as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>
>Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
>---
> admin/patron-attr-types.pl | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
>diff --git a/admin/patron-attr-types.pl b/admin/patron-attr-types.pl
>index 9a5fce2..72c13a9 100755
>--- a/admin/patron-attr-types.pl
>+++ b/admin/patron-attr-types.pl
>@@ -86,10 +86,10 @@ sub add_attribute_type_form {
> 
>     my $branches = Koha::Libraries->search( {}, { order_by => ['branchname'] } )->unblessed;
>     my @branches_loop;
>-    foreach my $branch (sort keys %$branches) {
>+    foreach my $branch (@$branches) {
>         push @branches_loop, {
>-            branchcode => $$branches{$branch}{branchcode},
>-            branchname => $$branches{$branch}{branchname},
>+            branchcode => $branch->{branchcode},
>+            branchname => $branch->{branchname},
>         };
>     }
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17308: 55627 | 55628 | 55629 | 55643