Bugzilla – Attachment 55653 Details for
Bug 17296
Failed to correctly configure AnonymousPatron with AnonSuggestions should display a warning in about
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 17296: Display warning if AnonymousPatron is not correctly set
PASSED-QA-Bug-17296-Display-warning-if-AnonymousPa.patch (text/plain), 2.66 KB, created by
Katrin Fischer
on 2016-09-18 12:36:36 UTC
(
hide
)
Description:
[PASSED QA] Bug 17296: Display warning if AnonymousPatron is not correctly set
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-09-18 12:36:36 UTC
Size:
2.66 KB
patch
obsolete
>From 64b85c1de7c407d804d44d2aeffd2bb17eb01ab5 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 14 Sep 2016 13:39:34 +0100 >Subject: [PATCH] [PASSED QA] Bug 17296: Display warning if AnonymousPatron is > not correctly set > >Bug 14655 added a warning to the about page ("System information" tab) >if the AnonymousPatron feature is not correctly configured. >But actually there is one case when it's not displayed. > >Test plan: >Set AnonymousPatron to a non existing patron >Set at least 1 borrowers.privacy == 2 >go on the about page. >Without this patch you do not get the warning >With this patch you will see "Some patrons have requested a privacy on >returning item but the AnonymousPatron pref is not set correctly. Set it >to a valid borrower number if you want that this feature works >correctly." > >Signed-off-by: Marc <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/about.tt | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >index f004c75..ad5eabd 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/about.tt >@@ -103,7 +103,7 @@ > </div> > > <div id="sysinfo"> >- [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || >+ [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist || > warnNoActiveCurrency || QueryParserError || warnIsRootUser || xml_config_warnings.size || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError %] > [% IF (warnIsRootUser) %] > <h2>Warning regarding current user</h2> >@@ -111,7 +111,7 @@ > <p>Please log in instead with a regular staff account. To create a staff account, create a library, a patron category 'Staff' and add a new patron. Then give this patron permissions from 'More' in the toolbar.</p> > [% END %] > >- [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || >+ [% IF warnPrefBiblioAddsAuthorities || warnPrefEasyAnalyticalRecords || warnPrefAnonymousPatron || warnPrefAnonymousPatron_PatronDoesNotExist || > warnNoActiveCurrency || QueryParserError || AutoSelfCheckPatronDoesNotHaveSelfCheckPerm || AutoSelfCheckPatronHasTooManyPerm || warnStatisticsFieldsError%] > <h2>Warnings regarding the system configuration</h2> > <table> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17296
:
55554
|
55555
| 55653