Attachment 55666 Details for Bug 17213 – [PASSED QA] Bug 17213 - Self registration cardnumber is not editable if errors found when form submitted

[patch] [PASSED QA] Bug 17213 - Self registration cardnumber is not editable if errors found when form submitted

PASSED-QA-Bug-17213---Self-registration-cardnumber.patch (text/plain), 1.72 KB, created by Katrin Fischer on 2016-09-18 21:02:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-09-18 21:02:57 UTC

Size: 1.72 KB

patch

obsolete

>From 7f307dbb7b8412a55815530233f2dba7416d6dec Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 29 Aug 2016 10:28:25 +0000
>Subject: [PATCH] [PASSED QA] Bug 17213 - Self registration cardnumber is not
> editable if errors found when form submitted
>
>To test:
>Enable self registration
>Make sure cardnumber is not in
>'PatronSelfRegistrationBorrowerUnwantedField'
>Enter an invalid or used cardnumber
>Submit form
>Note errors appears correctly but cardnumber is not editable
>Apply Patch
>Enter an invalid or used cardnumber
>Submit form
>Note errors appears correctly and cardnumber is editable
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>index 71b45c8..f231015 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-memberentry.tt
>@@ -134,7 +134,7 @@
>                                     [% END %]
>                                     Library card number:
>                                     </label>
>-                                    [% IF borrower %]
>+                                    [% IF borrower && !(cardnumber_wrong_length || cardnumber_already_exists) %]
>                                         [% borrower.cardnumber %]
>                                     [% ELSE %]
>                                         <input type="text" id="borrower_cardnumber" name="borrower_cardnumber" value="[% borrower.cardnumber %]" />
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17213: 54970 | 54971 | 55097 | 55449 | 55450 | 55530 | 55531 | 55665 | 55666 | 55667