Attachment 55711 Details for Bug 17316 – Bug 17316: Do not display the list's name if the user does not have permission - OPAC

[patch] Bug 17316: Do not display the list's name if the user does not have permission - OPAC

Bug-17316-Do-not-display-the-lists-name-if-the-use.patch (text/plain), 2.13 KB, created by Marc Véron on 2016-09-20 09:17:21 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Marc Véron

Created: 2016-09-20 09:17:21 UTC

Size: 2.13 KB

patch

obsolete

>From 35a6d58a49bef2e70d54657f164c2f33de7c038c Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Tue, 20 Sep 2016 09:55:25 +0100
>Subject: [PATCH] Bug 17316: Do not display the list's name if the user does
> not have permission - OPAC
>MIME-Version: 1.0
>Content-Type: text/plain; charset=UTF-8
>Content-Transfer-Encoding: 8bit
>
>At the OPAC, if a user manipulate the URL to show a list (s)he is not
>allowed to view, the list's name will be displayed anyway.
>
>Test plan:
>- Create a private list with user A
>- Copy the op=view URL and access it with user B logged in
>=> Without this patch, you will see the rss icon, the list's name and
>the "add list" button
>=> Without this patch, only the "unauthorized" box will be displayed
>
>Followed test plan, works as expected.
>Signed-off-by: Marc VÃ©ron <veron@veron.ch>
>---
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt | 2 +-
> opac/opac-shelves.pl                                     | 1 +
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>index 4050672..0e20fcf 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-shelves.tt
>@@ -153,7 +153,7 @@
>                     </div>
>                 [% END %]
> 
>-                    [% IF op == 'view' %]
>+                    [% IF shelf AND op == 'view' %]
>                         <h3>
>                             [% shelf.shelfname |html %]
>                             <a href="[% OPACBaseURL %]/cgi-bin/koha/opac-shelves.pl?rss=1&amp;op=view&amp;shelfnumber=[% shelf.shelfnumber %]" class="rss-list-link noprint">
>diff --git a/opac/opac-shelves.pl b/opac/opac-shelves.pl
>index 25120e7..065f517 100755
>--- a/opac/opac-shelves.pl
>+++ b/opac/opac-shelves.pl
>@@ -339,6 +339,7 @@ if ( $op eq 'view' ) {
>             }
>         } else {
>             push @messages, { type => 'error', code => 'unauthorized_on_view' };
>+            undef $shelf;
>         }
>     } else {
>         push @messages, { type => 'error', code => 'does_not_exist' };
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 17316: 55707 | 55708 | 55709 | 55710 | 55711 | 55712 | 55802 | 55803