Bugzilla – Attachment 55732 Details for
Bug 17307
Some edit buttons/links for patrons do not work
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17307: Smaller counter-patch
Bug-17307-Smaller-counter-patch.patch (text/plain), 1.32 KB, created by
Andreas Roussos
on 2016-09-21 06:30:06 UTC
(
hide
)
Description:
Bug 17307: Smaller counter-patch
Filename:
MIME Type:
Creator:
Andreas Roussos
Created:
2016-09-21 06:30:06 UTC
Size:
1.32 KB
patch
obsolete
>From 167575677285bfaa89757b43ea066c3d18f91135 Mon Sep 17 00:00:00 2001 >From: Mark Tompsett <mtompset@hotmail.com> >Date: Mon, 19 Sep 2016 12:38:43 -0400 >Subject: [PATCH] Bug 17307: Smaller counter-patch > >Given that the issue is trying to call a method on something that isn't >an object, because the category code doesn't exist, then why is it >even trying to change the expiry date? A simple postfix if fixes it. > >Signed-off-by: Andreas Roussos <arouss1980@gmail.com> >Applied counter-patch by M. Tompsett. All three patron 'Edit' links >mentioned in previous patch's test plan work fine. >--- > members/memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 413920b..1b100b0 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -372,7 +372,7 @@ if ($op eq 'save' || $op eq 'insert'){ > if ( ($op eq 'modify' || $op eq 'insert' || $op eq 'save'|| $op eq 'duplicate') and ($step == 0 or $step == 3 )){ > unless ($newdata{'dateexpiry'}){ > my $patron_category = Koha::Patron::Categories->find( $newdata{categorycode} ); >- $newdata{'dateexpiry'} = $patron_category->get_expiry_date( $newdata{dateenrolled} ); >+ $newdata{'dateexpiry'} = $patron_category->get_expiry_date( $newdata{dateenrolled} ) if $patron_category; > } > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17307
:
55623
|
55698
|
55732
|
55760
|
55805