Bugzilla – Attachment 55738 Details for
Bug 5670
Housebound Readers Module
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 5670: [QA Followup] Small QA fixes.
Bug-5670-QA-Followup-Small-QA-fixes.patch (text/plain), 2.38 KB, created by
Alex Sassmannshausen
on 2016-09-21 17:02:28 UTC
(
hide
)
Description:
Bug 5670: [QA Followup] Small QA fixes.
Filename:
MIME Type:
Creator:
Alex Sassmannshausen
Created:
2016-09-21 17:02:28 UTC
Size:
2.38 KB
patch
obsolete
>From c9c8ca6971258c479d0f32083ed9f77d83515b05 Mon Sep 17 00:00:00 2001 >From: Alex Sassmannshausen <alex.sassmannshausen@ptfs-europe.com> >Date: Mon, 19 Sep 2016 15:21:19 +0200 >Subject: [PATCH] Bug 5670: [QA Followup] Small QA fixes. > >* koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt: Remove > `console.log` invocations. >* members/housebound.pl ($houseboundvisits, $chooser, $deliverer): > Remove unused variables. >--- > koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt | 6 ++---- > members/housebound.pl | 3 +-- > 2 files changed, 3 insertions(+), 6 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >index 4656160..f0a60f9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/housebound.tt >@@ -196,8 +196,7 @@ > </ol> > </fieldset> > <fieldset class="action"> >- <input type="submit" value="Save changes" name="save" >- onclick="console.log('Must validate form');" /> >+ <input type="submit" value="Save changes" name="save" /> > <a class="cancel" > href="/cgi-bin/koha/members/housebound.pl?borrowernumber=[% borrowernumber %]"> > Cancel >@@ -318,8 +317,7 @@ > </ol> > </fieldset> > <fieldset class="action"> >- <input type="submit" value="Save" name="save" >- onclick="console.log('Must validate form');" /> >+ <input type="submit" value="Save" name="save" /> > <a class="cancel" > href="/cgi-bin/koha/members/housebound.pl?borrowernumber=[% borrowernumber %]"> > Cancel >diff --git a/members/housebound.pl b/members/housebound.pl >index df7e058..fe26d82 100755 >--- a/members/housebound.pl >+++ b/members/housebound.pl >@@ -77,8 +77,7 @@ if ( $visit_id ) { > } > > # Main processing >-my ( $houseboundvisits, $deliverers, $choosers ); >-my ( $houseboundvisit, $deliverer, $chooser ); >+my ( $deliverers, $choosers, $houseboundvisit ); > > if ( $method eq 'updateconfirm' and $houseboundprofile ) { > # We have received the input from the profile edit form. We must save the >-- >2.9.3
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5670
:
3038
|
22162
|
22163
|
22164
|
22165
|
26816
|
27288
|
50930
|
51377
|
51875
|
54384
|
54385
|
55326
|
55334
|
55335
|
55336
|
55734
|
55735
|
55736
|
55737
|
55738
|
55739
|
55865
|
55866
|
55867
|
55890
|
55891
|
56298
|
56299
|
56300
|
56301
|
56302
|
56308
|
56337
|
56341
|
56346
|
56347
|
56348
|
56349
|
56350
|
56351
|
56352
|
56353
|
56354
|
56355
|
56356
|
56357
|
56358
|
56359
|
56360
|
56361
|
56362
|
56363
|
56364
|
56365
|
56366
|
56367
|
56368
|
56369
|
56580
|
56581
|
56582
|
56583
|
56584
|
56585
|
56586
|
56587
|
56588
|
56589
|
56590
|
56591
|
56592
|
56593
|
56594
|
56595
|
56596
|
56597
|
56598
|
56599
|
56600
|
56601
|
56602
|
56603
|
56604
|
56605
|
56606