Attachment 55751 Details for Bug 17328 – Bug 17328 - categories' many int fields cannot be NULL

[patch] Bug 17328 - categories' many int fields cannot be NULL

Bug-17328---categories-many-int-fields-cannot-be-N.patch (text/plain), 1.77 KB, created by Blou on 2016-09-22 14:27:12 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Blou

Created: 2016-09-22 14:27:12 UTC

Size: 1.77 KB

patch

obsolete

>From f227a9b83680edc36ef9a4d57b4074cbd12a7110 Mon Sep 17 00:00:00 2001
>From: Blou <philippe.blouin@inlibro.com>
>Date: Thu, 22 Sep 2016 10:24:18 -0400
>Subject: [PATCH] Bug 17328 - categories' many int fields cannot be NULL
>
>This fixes the code, but the DB should also be fixed with default values.
>---
> admin/categories.pl | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/admin/categories.pl b/admin/categories.pl
>index 358ef7d..58eb71c 100755
>--- a/admin/categories.pl
>+++ b/admin/categories.pl
>@@ -80,14 +80,14 @@ elsif ( $op eq 'add_validate' ) {
> 
>     my $categorycode = $input->param('categorycode');
>     my $description = $input->param('description');
>-    my $enrolmentperiod = $input->param('enrolmentperiod');
>+    my $enrolmentperiod = $input->param('enrolmentperiod') || 0;
>     my $enrolmentperioddate = $input->param('enrolmentperioddate') || undef;
>-    my $upperagelimit = $input->param('upperagelimit');
>-    my $dateofbirthrequired = $input->param('dateofbirthrequired');
>-    my $enrolmentfee = $input->param('enrolmentfee');
>-    my $reservefee = $input->param('reservefee');
>+    my $upperagelimit = $input->param('upperagelimit') || 0;
>+    my $dateofbirthrequired = $input->param('dateofbirthrequired') || 0;
>+    my $enrolmentfee = $input->param('enrolmentfee') || 0.0;
>+    my $reservefee = $input->param('reservefee') || 0.0;
>     my $hidelostitems = $input->param('hidelostitems');
>-    my $overduenoticerequired = $input->param('overduenoticerequired');
>+    my $overduenoticerequired = $input->param('overduenoticerequired') || 0;
>     my $category_type = $input->param('category_type');
>     my $BlockExpiredPatronOpacActions = $input->param('BlockExpiredPatronOpacActions');
>     my $checkPrevCheckout = $input->param('checkprevcheckout');
>-- 
>2.1.0

Actions: View | Diff | Splinter Review

Attachments on bug 17328: 55748 | 55749 | 55751 | 55752 | 55841