Bugzilla – Attachment 55827 Details for
Bug 17327
Item level holds no longer enforced
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17327: (QA followup) Remove Carp::Always which is not used
Bug-17327-QA-followup-Remove-CarpAlways-which-is-n.patch (text/plain), 1.43 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-09-26 18:00:56 UTC
(
hide
)
Description:
Bug 17327: (QA followup) Remove Carp::Always which is not used
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-09-26 18:00:56 UTC
Size:
1.43 KB
patch
obsolete
>From 7f98eab4817ad6a7e869a620685bdd248c964129 Mon Sep 17 00:00:00 2001 >From: Tomas Cohen Arazi <tomascohen@theke.io> >Date: Mon, 26 Sep 2016 14:55:16 -0300 >Subject: [PATCH] Bug 17327: (QA followup) Remove Carp::Always which is not > used > >This patch removes the need for Carp::Always in .../Reserves/MultiplePerRecord.t >which is not actually used. > >It also removes 'undef' from Koha::Holds::forced_hold_level's last return, to comply with >our QA rules. > >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > Koha/Holds.pm | 2 +- > t/db_dependent/Reserves/MultiplePerRecord.t | 1 - > 2 files changed, 1 insertion(+), 2 deletions(-) > >diff --git a/Koha/Holds.pm b/Koha/Holds.pm >index 6dc0c9e..038e31c 100644 >--- a/Koha/Holds.pm >+++ b/Koha/Holds.pm >@@ -77,7 +77,7 @@ sub forced_hold_level { > my $record_level_count = $self->search( { itemnumber => undef } )->count(); > return 'record' if $record_level_count > 0; > >- return undef; >+ return; > } > > =head3 type >diff --git a/t/db_dependent/Reserves/MultiplePerRecord.t b/t/db_dependent/Reserves/MultiplePerRecord.t >index 9771051..d2da653 100755 >--- a/t/db_dependent/Reserves/MultiplePerRecord.t >+++ b/t/db_dependent/Reserves/MultiplePerRecord.t >@@ -17,7 +17,6 @@ > # You should have received a copy of the GNU General Public License > # along with Koha; if not, see <http://www.gnu.org/licenses>. > >-use Carp::Always; > use Modern::Perl; > > use Test::More tests => 38; >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17327
:
55744
|
55745
|
55761
|
55762
|
55825
|
55826
| 55827