Bugzilla – Attachment 55835 Details for
Bug 17216
Add a new table to store authorized value categories
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17216: Internal AV should be correctly handled when creating a new category
Bug-17216-Internal-AV-should-be-correctly-handled-.patch (text/plain), 1.54 KB, created by
Jonathan Druart
on 2016-09-27 08:31:32 UTC
(
hide
)
Description:
Bug 17216: Internal AV should be correctly handled when creating a new category
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-09-27 08:31:32 UTC
Size:
1.54 KB
patch
obsolete
>From 76fcf07de8583717c3dee17a501d47321ab760ce Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 27 Sep 2016 09:24:57 +0100 >Subject: [PATCH] Bug 17216: Internal AV should be correctly handled when > creating a new category > >--- > admin/authorised_values.pl | 8 ++++++-- > 1 file changed, 6 insertions(+), 2 deletions(-) > >diff --git a/admin/authorised_values.pl b/admin/authorised_values.pl >index 5aecc3c..bb94e23 100755 >--- a/admin/authorised_values.pl >+++ b/admin/authorised_values.pl >@@ -167,7 +167,11 @@ if ($op eq 'add_form') { > ); > > if ( $already_exists ) { >- push @messages, {type => 'error', code => 'cat_already_exists' }; >+ if ( $new_category eq 'branches' or $new_category eq 'itemtypes' or $new_category eq 'cn_source' ) { >+ push @messages, {type => 'error', code => 'invalid_category_name' }; >+ } else { >+ push @messages, {type => 'error', code => 'cat_already_exists' }; >+ } > } > else { # Insert > my $av = Koha::AuthorisedValueCategory->new( { >@@ -182,11 +186,11 @@ if ($op eq 'add_form') { > push @messages, {type => 'error', code => 'error_on_insert_cat' }; > } else { > push @messages, { type => 'message', code => 'success_on_insert_cat' }; >+ $searchfield = $new_category; > } > } > > $op = 'list'; >- $searchfield = $new_category; > } elsif ($op eq 'delete') { > my $av = Koha::AuthorisedValues->new->find( $input->param('id') ); > my $deleted = eval {$av->delete}; >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17216
:
54979
|
54980
|
54981
|
54982
|
54983
|
54984
|
54985
|
54987
|
54988
|
54989
|
54990
|
54991
|
54992
|
54993
|
55003
|
55004
|
55005
|
55008
|
55009
|
55010
|
55011
|
55021
|
55022
|
55023
|
55024
|
55025
|
55026
|
55027
|
55028
|
55029
|
55030
|
55031
|
55032
|
55047
|
55207
|
55208
|
55209
|
55210
|
55211
|
55212
|
55213
|
55214
|
55215
|
55216
|
55217
|
55218
|
55365
|
55366
|
55367
|
55368
|
55369
|
55370
|
55371
|
55372
|
55373
|
55374
|
55375
|
55376
|
55692
|
55693
|
55835
|
55840
|
56202
|
56203
|
56204
|
56205
|
56206
|
56207
|
56208
|
56209
|
56210
|
56211
|
56212
|
56213
|
56214
|
56215
|
56216
|
56217
|
56619
|
57729