Attachment 55862 Details for Bug 17292 – Bug 17292: Follow up - tweak to make it pass cleaner

[patch] Bug 17292: Follow up - tweak to make it pass cleaner

Bug-17292-Follow-up---tweak-to-make-it-pass-cleane.patch (text/plain), 1.38 KB, created by Jonathan Druart on 2016-09-28 08:08:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-09-28 08:08:41 UTC

Size: 1.38 KB

patch

obsolete

>From 6fdcd8396fdaccffbfdf9e9545a8669fec31e8db Mon Sep 17 00:00:00 2001
>From: Mark Tompsett <mtompset@hotmail.com>
>Date: Sun, 18 Sep 2016 20:47:33 -0400
>Subject: [PATCH] Bug 17292: Follow up - tweak to make it pass cleaner
>
>remove a 'my'
>next if not defined subscriptions.
>
>Signed-off-by: Mark Tompsett <mtompset@hotmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> installer/data/mysql/updatedatabase.pl | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
>diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl
>index 6521f40..cc6207c 100755
>--- a/installer/data/mysql/updatedatabase.pl
>+++ b/installer/data/mysql/updatedatabase.pl
>@@ -11477,9 +11477,10 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) {
>     my $sth3 = $dbh->prepare("UPDATE serials SET serialseq_x = ?, serialseq_y = ?, serialseq_z = ? WHERE serialid = ?");
> 
>     foreach my $subscription ( $sth->fetchrow_hashref() ) {
>+        next if !defined($subscription);
>         my $number_pattern = $subscription->numberpattern();
>         $sth2->execute( $subscription->{numberpattern} );
>-        my $number_pattern = $sth2->fetchrow_hashref();
>+        $number_pattern = $sth2->fetchrow_hashref();
> 
>         my $numbering_method = $number_pattern->{numberingmethod};
>         # Get all the data between the enumeration values, we need
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 17292: 55502 | 55672 | 55673 | 55674 | 55861 | 55862 | 56734