Attachment 55864 Details for Bug 17341 – Bug 17341: Enhance the report action button on guided_reports.pl

[patch] Bug 17341: Enhance the report action button on guided_reports.pl

Bug-17341-Enhance-the-report-action-button-on-guid.patch (text/plain), 5.37 KB, created by Jonathan Druart on 2016-09-28 08:21:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-09-28 08:21:18 UTC

Size: 5.37 KB

patch

obsolete

>From e7915707c460abd6fc8b49fe50dcf6ad2ecad59d Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Mon, 26 Sep 2016 12:37:29 +0200
>Subject: [PATCH] Bug 17341: Enhance the report action button on
> guided_reports.pl
>
>Test plan:
>1) Apply the patch
>2) Go to saved reports page
>3) In the most right column of table you should see "Run" button with
> caret button, the first one should run the report, the second one
> should work asi menu trigger
>4) Ensure that all report actions works as before
>
>Signed-off-by: Owen Leonard <oleonard@myacpl.org>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> .../en/modules/reports/guided_reports_start.tt | 30 +++++++++++-----------
> 1 file changed, 15 insertions(+), 15 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index fba4170..71fed7f 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -371,21 +371,21 @@ canned reports and writing custom SQL reports.
> </td>
> <td>
> <div class="dropup">
>- <a class="btn btn-mini dropdown-toggle" id="reportactions[% savedreport.id %]" role="button" data-toggle="dropdown" href="#">
>- Actions 
>- </a>
>- <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="reportactions[% savedreport.id %]">
>- <li><a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Show%20SQL"> Show</a></li>
>- [% IF ( CAN_user_reports_create_reports ) %]
>- <li><a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Edit%20SQL"> Edit</a></li>
>- <li><a title="Duplicate this saved report" href="/cgi-bin/koha/reports/guided_reports.pl?phase=Create report from SQL&amp;sql=[% savedreport.savedsql |uri %]&amp;reportname=[% savedreport.report_name |uri %]&amp;notes=[% savedreport.notes |uri %]"> Duplicate</a></li>
>- [% END %]
>- <li><a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Run%20this%20report"> Run</a></li>
>- <li><a href="/cgi-bin/koha/tools/scheduler.pl?id=[% savedreport.id %]"> Schedule</a></li>
>- [% IF ( CAN_user_reports_delete_reports ) %]
>- <li><a class="confirmdelete" title="Delete this saved report" href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Delete%20Saved"> Delete</a></li>
>- [% END %]
>- </ul>
>+ <div class="btn-group">
>+ <a class="btn btn-mini" role="button" href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Run%20this%20report"> Run</a>
>+ <a class="btn btn-mini dropdown-toggle" id="reportactions[% savedreport.id %]" role="button" data-toggle="dropdown" href="#"></a>
>+ <ul class="dropdown-menu pull-right" role="menu" aria-labelledby="reportactions[% savedreport.id %]">
>+ <li><a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Show%20SQL"> Show</a></li>
>+ [% IF ( CAN_user_reports_create_reports ) %]
>+ <li><a href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Edit%20SQL"> Edit</a></li>
>+ <li><a title="Duplicate this saved report" href="/cgi-bin/koha/reports/guided_reports.pl?phase=Create report from SQL&amp;sql=[% savedreport.savedsql |uri %]&amp;reportname=[% savedreport.report_name |uri %]&amp;notes=[% savedreport.notes |uri %]"> Duplicate</a></li>
>+ [% END %]
>+ <li><a href="/cgi-bin/koha/tools/scheduler.pl?id=[% savedreport.id %]"> Schedule</a></li>
>+ [% IF ( CAN_user_reports_delete_reports ) %]
>+ <li><a class="confirmdelete" title="Delete this saved report" href="/cgi-bin/koha/reports/guided_reports.pl?reports=[% savedreport.id %]&amp;phase=Delete%20Saved"> Delete</a></li>
>+ [% END %]
>+ </ul>
>+ </div>
> </div>
> </td>
> </tr>
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 17341: 55821 | 55822 | 55864