Attachment 55869 Details for Bug 17282 – Bug 17282: Remove use of onclick

[patch] Bug 17282: Remove use of onclick

Bug-17282-Remove-use-of-onclick.patch (text/plain), 2.04 KB, created by Jonathan Druart on 2016-09-28 10:10:10 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-09-28 10:10:10 UTC

Size: 2.04 KB

patch

obsolete

>From 848b3d34160667a7146dbe4bf8c793377e1cf312 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Wed, 28 Sep 2016 11:04:23 +0100
>Subject: [PATCH] Bug 17282: Remove use of onclick
>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc                    | 2 +-
> .../intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt     | 4 ++++
> 2 files changed, 5 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>index 1d69a6f..c0fa2a6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/chart.inc
>@@ -37,7 +37,7 @@
>                     <fieldset class="chart-column-conf" id="column_[% column %]" style="display: inline !important;">
>                         <legend>
>                             Column [% column %]
>-                            <a class="chart-column-delete" href="#" onclick="removeColumn('column_[% column %]'); return false;">
>+                            <a class="chart-column-delete" href="#" data-column="[% column %]">
>                                 <img src="[% interface %]/[% theme %]/img/x.png" alt="Delete" />
>                             </a>
>                         </legend>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>index 883631d..3bab9a6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/guided_reports_start.tt
>@@ -861,6 +861,10 @@ canned reports and writing custom SQL reports.</p>
>             $('.chart-column-delete').remove();
>         }
> 
>+        $(".chart-column-delete").on('click', function(e){
>+            e.preventDefault();
>+            removeColumn('column_' + $(this).data('column'));
>+        })
> 
>         $('#download-chart').click(function() {
>             var svg = '<svg>' + $('#chart svg').html() + '</svg>';
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 17282: 55412 | 55442 | 55444 | 55480 | 55582 | 55586 | 55588 | 55604 | 55605 | 55606 | 55607 | 55868 | 55869 | 62529 | 63565 | 63566 | 63567 | 63568 | 63569 | 63570 | 63571 | 67225 | 67226 | 67227 | 67228 | 67229 | 67230 | 67231 | 69174 | 69429 | 69430 | 69493 | 79182 | 79230 | 79308 | 79309 | 79310 | 79311 | 79312 | 79313 | 79337 | 79338 | 79339