Attachment 55872 Details for Bug 15900 – Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment

[patch] Bug 15900 - Remove use of recordpayment in ProcessOfflinePayment

Bug-15900---Remove-use-of-recordpayment-in-Process.patch (text/plain), 1.37 KB, created by Jonathan Druart on 2016-09-28 11:08:07 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-09-28 11:08:07 UTC

Size: 1.37 KB

patch

obsolete

>From 7fddb760b070d004163cb32c170516e38ef08dbf Mon Sep 17 00:00:00 2001
>From: Kyle M Hall <kyle@bywatersolutions.com>
>Date: Wed, 24 Feb 2016 15:11:53 +0000
>Subject: [PATCH] Bug 15900 - Remove use of recordpayment in
> ProcessOfflinePayment
>
>Test plan:
>1) Apply this patch
>2) prove t/db_dependent/Circulation.t
>
>Signed-off-by: Josef Moravec <josef.moravec@gmail.com>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> C4/Circulation.pm | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
>
>diff --git a/C4/Circulation.pm b/C4/Circulation.pm
>index 4d0e7d5..470febc 100644
>--- a/C4/Circulation.pm
>+++ b/C4/Circulation.pm
>@@ -44,6 +44,7 @@ use C4::RotatingCollections qw(GetCollectionItemBranches);
> use Algorithm::CheckDigits;
> 
> use Data::Dumper;
>+use Koha::Account;
> use Koha::DateUtils;
> use Koha::Calendar;
> use Koha::Items;
>@@ -3835,10 +3836,10 @@ sub ProcessOfflineIssue {
> sub ProcessOfflinePayment {
>     my $operation = shift;
> 
>-    my $borrower = C4::Members::GetMemberDetails( undef, $operation->{cardnumber} ); # Get borrower from operation cardnumber
>+    my $patron = Koha::Borrowers->find( { cardnumber => $operation->{cardnumber} });
>     my $amount = $operation->{amount};
> 
>-    recordpayment( $borrower->{borrowernumber}, $amount );
>+    Koha::Account->new( { patron_id => $patron->id } )->pay( { amount => $amount } );
> 
>     return "Success."
> }
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 15900: 48337 | 52142 | 54742 | 55261 | 55872 | 55873