Bugzilla – Attachment 55885 Details for
Bug 15131
Give SCO separate control for AllowItemsOnHoldCheckout
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats
Bug-15131-Add-AllowItemsOnHoldCheckoutSCO-to-Usage.patch (text/plain), 2.22 KB, created by
Jonathan Druart
on 2016-09-28 12:43:08 UTC
(
hide
)
Description:
Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-09-28 12:43:08 UTC
Size:
2.22 KB
patch
obsolete
>From 37b4ec2a146481f0e4f750d78f62d5cf861adb7a Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 28 Sep 2016 13:37:05 +0100 >Subject: [PATCH] Bug 15131: Add AllowItemsOnHoldCheckoutSCO to UsageStats > >Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >--- > C4/UsageStats.pm | 1 + > t/db_dependent/UsageStats.t | 15 +++++++++++++-- > 2 files changed, 14 insertions(+), 2 deletions(-) > >diff --git a/C4/UsageStats.pm b/C4/UsageStats.pm >index b8dbb26..cf8b98e 100644 >--- a/C4/UsageStats.pm >+++ b/C4/UsageStats.pm >@@ -121,6 +121,7 @@ sub BuildReport { > AllFinesNeedOverride > AllowFineOverride > AllowItemsOnHoldCheckout >+ AllowItemsOnHoldCheckoutSCO > AllowNotForLoanOverride > AllowRenewalLimitOverride > AllowReturnToBranch >diff --git a/t/db_dependent/UsageStats.t b/t/db_dependent/UsageStats.t >index 76abe49..bb15e88 100644 >--- a/t/db_dependent/UsageStats.t >+++ b/t/db_dependent/UsageStats.t >@@ -15,9 +15,10 @@ > # with Koha; if not, see <http://www.gnu.org/licenses>. > > use Modern::Perl; >-use Test::More tests => 545; >+use Test::More tests => 57; > use t::lib::Mocks qw(mock_preference); > use POSIX qw(strftime); >+use Data::Dumper; > > BEGIN { > use_ok('C4::UsageStats'); >@@ -372,6 +373,7 @@ sub mocking_systempreferences_to_a_set_value { > AllFinesNeedOverride > AllowFineOverride > AllowItemsOnHoldCheckout >+ AllowItemsOnHoldCheckoutSCO > AllowNotForLoanOverride > AllowRenewalLimitOverride > AllowReturnToBranch >@@ -586,8 +588,17 @@ sub mocking_systempreferences_to_a_set_value { > sub verif_systempreferences_values { > my ( $report, $value_to_test ) = @_; > >+ my @missings; > foreach my $key ( keys %{$report->{systempreferences}} ) { >- is( $report->{systempreferences}->{$key}, $value_to_test, "\$report->{systempreferences}->{$key} = $value_to_test" ); >+ if ( $report->{systempreferences}->{$key} ne $value_to_test ) { >+ warn $key; >+ push @missings, $key; >+ } >+ } >+ unless ( @missings ) { >+ ok(1, 'All prefs are present'); >+ } else { >+ ok(0, 'Some prefs are missing: ' . Dumper(\@missings)); > } > } > >-- >2.8.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15131
:
53273
|
53274
|
55696
|
55697
|
55883
|
55884
| 55885