Bugzilla – Attachment 55966 Details for
Bug 17384
Categories do not display in patron editing form if they have only one category assigned
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17384 - Categories do not display in patron editing form if they have only one category assigned
Bug-17384---Categories-do-not-display-in-patron-ed.patch (text/plain), 1.89 KB, created by
Chris Cormack
on 2016-10-02 05:36:55 UTC
(
hide
)
Description:
Bug 17384 - Categories do not display in patron editing form if they have only one category assigned
Filename:
MIME Type:
Creator:
Chris Cormack
Created:
2016-10-02 05:36:55 UTC
Size:
1.89 KB
patch
obsolete
>From 4173e8fa8df527b5526f5555e805702a9f189715 Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Marc=20V=C3=A9ron?= <veron@veron.ch> >Date: Fri, 30 Sep 2016 17:48:44 +0200 >Subject: [PATCH] Bug 17384 - Categories do not display in patron editing form > if they have only one category assigned > >To reproduce: >- Go to Home > Administration > Patron categories >- Make sure that you have only one category for a category type. > Examples: Only one category "Staff" for category type "Staff" or > Only one category "Library" for category type "Org." >- Edit a patron or create a new patron >- Verify that categories of examples above do not show up in category drop down >- Go back to Home > Administration > Patron categories and add categories to > both category types >- Edit or create a new patron. Veryfy that categories show up in dropdown. > >To test: >- Apply patch >- Make sure you have a category type with only one category assigned > (e.g. category taype Staff with category Staff) >- Edit a patron or create a new patron. Verify that the category > shows up in categroy drop down. > >- Additional test: Verify that template param 'catcode' from removed line > is not used in template memberentrygen.tt > >Signed-off-by: Chris Cormack <chris@bigballofwax.co.nz> >--- > members/memberentry.pl | 1 - > 1 file changed, 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index 1b100b0..8fc5d9b 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -524,7 +524,6 @@ my $no_add; > foreach my $category_type (qw(C A S P I X)) { > my $patron_categories = Koha::Patron::Categories->search_limited({ category_type => $category_type }, {order_by => ['categorycode']}); > $no_categories = 0 if $patron_categories->count > 0; >- $template->param( 'catcode' => $patron_categories->next ) if $patron_categories->count == 1; > > my @categoryloop; > while ( my $patron_category = $patron_categories->next ) { >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17384
:
55962
|
55966
|
55973