Attachment 56015 Details for Bug 16769 – Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter

[patch] Bug 16769: [QA Follow-up] Remove unsupported deepcopy parameter

Bug-16769-QA-Follow-up-Remove-unsupported-deepcopy.patch (text/plain), 1.03 KB, created by Nick Clemens (kidclamp) on 2016-10-04 09:57:18 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2016-10-04 09:57:18 UTC

Size: 1.03 KB

patch

obsolete

>From 1c7ead859932c899681099f921e2064732dadc45 Mon Sep 17 00:00:00 2001
>From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>Date: Wed, 27 Jul 2016 16:00:43 +0200
>Subject: [PATCH] Bug 16769: [QA Follow-up] Remove unsupported deepcopy
> parameter
>
>Routine C4/Koha/GetAuthorisedValues adds deepcopy => 1 to the options of
>set_in_cache. This makes no sense (anymore?). Is not supported or passed
>further. So better remove it.
>
>Test plan:
>Run t/db_dependent/Koha.t (with Test::Deep available to minimize confusion)
>
>Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl>
>
>Signed-off-by: Nick Clemens <nick@bywatersolutions.com>
>---
> C4/Koha.pm | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/C4/Koha.pm b/C4/Koha.pm
>index 0ff4851..de4e6a4 100644
>--- a/C4/Koha.pm
>+++ b/C4/Koha.pm
>@@ -984,7 +984,7 @@ sub GetAuthorisedValues {
>     }
>     $sth->finish;
> 
>-    $cache->set_in_cache( $cache_key, \@results, { deepcopy => 1, expiry => 5 } );
>+    $cache->set_in_cache( $cache_key, \@results, { expiry => 5 } );
>     return \@results;
> }
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16769: 52512 | 53751 | 53752 | 53753 | 56013 | 56014 | 56015