Attachment 56061 Details for Bug 14242 – Bug 14242 Follow up, renaming syspref, there should be no changes

[patch] Bug 14242 Follow up, renaming syspref, there should be no changes

Bug-14242-Follow-up-renaming-syspref-there-should-.patch (text/plain), 6.91 KB, created by Chris Cormack on 2016-10-05 20:06:57 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Cormack

Created: 2016-10-05 20:06:57 UTC

Size: 6.91 KB

patch

obsolete

>From 146aad778a19924751cb9441d7f8534d7e321bc1 Mon Sep 17 00:00:00 2001
>From: Chris Cormack <chrisc@catalyst.net.nz>
>Date: Fri, 30 Sep 2016 00:48:04 +0000
>Subject: [PATCH] Bug 14242 Follow up, renaming syspref, there should be no
> changes
>
>OPACAutoFill -> OPACSuggestionAutoFill
>---
> installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql  | 2 +-
> installer/data/mysql/sysprefs.sql                                 | 2 +-
> .../intranet-tmpl/prog/en/modules/admin/preferences/opac.pref     | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc         | 2 +-
> koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt      | 8 ++++----
> 5 files changed, 8 insertions(+), 8 deletions(-)
>
>diff --git a/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql b/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql
>index 3cb4ffb..1abb6ab 100644
>--- a/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql
>+++ b/installer/data/mysql/atomicupdate/bug_14242-autofill_syspref.sql
>@@ -1 +1 @@
>-INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`,`type`) VALUES ('OPACAutoFill', '0', NULL, 'Automaticly fill forms with data from Google Books API','YesNo');
>+INSERT IGNORE INTO systempreferences (`variable`, `value`, `options`, `explanation`,`type`) VALUES ('OPACSuggestionAutoFill', '0', NULL, 'Automaticly fill forms with data from Google Books API','YesNo');
>diff --git a/installer/data/mysql/sysprefs.sql b/installer/data/mysql/sysprefs.sql
>index 9d89af6..ccfeb28 100644
>--- a/installer/data/mysql/sysprefs.sql
>+++ b/installer/data/mysql/sysprefs.sql
>@@ -278,7 +278,7 @@ INSERT INTO systempreferences ( `variable`, `value`, `options`, `explanation`, `
> ('OAI-PMH:MaxCount','50',NULL,'OAI-PMH maximum number of records by answer to ListRecords and ListIdentifiers queries','Integer'),
> ('OCLCAffiliateID','','','Use with FRBRizeEditions and XISBN. You can sign up for an AffiliateID here: http://www.worldcat.org/wcpa/do/AffiliateUserServices?method=initSelfRegister','free'),
> ('OPACAcquisitionDetails','0','','Show the acquisition details at the OPAC','YesNo'),
>-('OPACAutoFill','0',NULL,'Automaticly fill forms with data from Google Books API','YesNo'),
>+('OPACSuggestionAutoFill','0',NULL,'Automaticly fill forms with data from Google Books API','YesNo'),
> ('OpacAddMastheadLibraryPulldown','0','','Adds a pulldown menu to select the library to search on the opac masthead.','YesNo'),
> ('OpacAdvSearchMoreOptions','pubdate,itemtype,language,subtype,sorting,location','Show search options for the expanded view (More options)','pubdate|itemtype|language|subtype|sorting|location','multiple'),
> ('OpacAdvSearchOptions','pubdate,itemtype,language,sorting,location','Show search options','pubdate|itemtype|language|subtype|sorting|location','multiple'),
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>index 1719a9c..d47fad6 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref
>@@ -503,7 +503,7 @@ OPAC:
>                   no: Don't display
>             - the acquisition details on OPAC detail pages.
>         -
>-            - pref: OPACAutoFill
>+            - pref: OPACSuggestionAutoFill
>               default: 0
>               choices:
>                   yes: Enable
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>index 309ae9a..9f78bd7 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/includes/opac-bottom.inc
>@@ -214,7 +214,7 @@ $.widget.bridge('uitooltip', $.ui.tooltip);
>     </script>
> [% END %]
> 
>-[% IF ( Koha.Preference('OPACAutoFill') ) %]
>+[% IF ( Koha.Preference('OPACSuggestionAutoFill') ) %]
>     <script type="text/javascript" src="[% interface %]/[% theme %]/js/autofill.js"></script>
> [% END %]
> 
>diff --git a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>index 0a155ef..087ba6e 100644
>--- a/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>+++ b/koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-suggestions.tt
>@@ -39,12 +39,12 @@
>                             <p>Only certain fields (marked in red) are required, but the more information you enter the easier it will be for the librarians to find the title you're requesting. The "Notes" field can be used to provide any additional information.</p>
> 
>                             <form action="/cgi-bin/koha/opac-suggestions.pl" method="post" id="add_suggestion_form">
>-                                [% IF Koha.Preference( 'OPACAutoFill' ) %]
>+                                [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>                                 <fieldset class="rows well" style="margin-bottom: 3em;padding-top: 5px;">
>                                     <label for="isbn">Standard number (ISBN, ISSN or other):</label><input type="text" id="isbn" name="isbn"  maxlength="80" />
>                                 </fieldset>
>                                 [% END %]
>-                                    <fieldset class="rows [% IF Koha.Preference( 'OPACAutoFill' ) %]well[% END %]">
>+                                    <fieldset class="rows [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]well[% END %]">
>                                     <ol>
>                                         <li><label for="title">Title:</label><input type="text" id="title" name="title" class="span6" maxlength="255" /></li>
>                                         <li><label for="author">Author:</label><input type="text" id="author" name="author" class="span6" maxlength="80" /></li>
>@@ -53,7 +53,7 @@
>                                             <label for="copyrightdate">Copyright date:</label><input type="text" id="copyrightdate" name="copyrightdate" pattern="[12]\d{3}" size="4" maxlength="4" />
>                                             </div>
>                                         </li>
>-                                        [% IF NOT Koha.Preference( 'OPACAutoFill' ) %]
>+                                        [% IF NOT Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>                                         <li><label for="isbn">Standard number (ISBN, ISSN or other):</label><input type="text" id="isbn" name="isbn" maxlength="80" /></li>
>                                         [% END %]
>                                         <li><label for="publishercode">Publisher:</label><input type="text" id="publishercode" name="publishercode" class="span6" maxlength="80" /></li>
>@@ -297,7 +297,7 @@
>         }
>     [% END %]
> 
>-    [% IF Koha.Preference( 'OPACAutoFill' ) %]
>+    [% IF Koha.Preference( 'OPACSuggestionAutoFill' ) %]
>     $(function() {
>         $('#isbn').autofill({
>             'volumeInfo.title': {target: 'title', effect: 'flash'},
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14242: 42002 | 55949 | 56061 | 56062 | 56070 | 56071 | 56072 | 56073 | 56074 | 56075 | 84760 | 84761 | 84762 | 84763 | 84764 | 84840 | 85031 | 85032 | 85033 | 85034 | 85035 | 89643 | 89662 | 90157 | 90158 | 90159 | 90160 | 90161 | 90162 | 90250 | 90251 | 90252 | 90253 | 90254 | 90255 | 103527 | 103528 | 103529 | 103530 | 103531 | 103532 | 103533 | 108695 | 108696 | 108697 | 108698 | 108699 | 108700 | 108701 | 110141 | 110142 | 110143 | 110144 | 110145 | 110146 | 110147 | 110148 | 110493 | 110494 | 110495 | 110496 | 110497 | 110498 | 110499 | 110500 | 110501 | 110990 | 112597 | 112598 | 112599 | 112600 | 112601 | 112602 | 112603 | 112604 | 112605 | 112606 | 112607 | 113162 | 113163 | 113164 | 113165 | 113166 | 113167 | 116620 | 116712 | 116968 | 116989 | 125380 | 125381 | 125382 | 131219 | 131220 | 131221 | 131222 | 133985 | 133986 | 133987 | 133988 | 134273 | 134274 | 134275 | 134276 | 134277 | 134278