Attachment 56082 Details for Bug 14876 – Bug 14876 (QA Followup) Don't show (0) as holds counts when no holds

[patch] Bug 14876 (QA Followup) Don't show (0) as holds counts when no holds

Bug-14876-QA-Followup-Dont-show-0-as-holds-counts-.patch (text/plain), 3.02 KB, created by Nick Clemens (kidclamp) on 2016-10-10 08:22:58 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Nick Clemens (kidclamp)

Created: 2016-10-10 08:22:58 UTC

Size: 3.02 KB

patch

obsolete

>From 81a481c694bfd7c3e2e460fac7c14bb7bce90d44 Mon Sep 17 00:00:00 2001
>From: Nick Clemens <nick@bywatersolutions.com>
>Date: Mon, 10 Oct 2016 08:21:27 +0000
>Subject: [PATCH] Bug 14876 (QA Followup)     Don't show (0) as holds counts
> when no holds
>
>---
> koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc | 2 +-
> koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt  | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>index 76c52f8..09e6824 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>+++ b/koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
>@@ -23,7 +23,7 @@
>     [% IF ( moredetailview ) %]<li class="active">[% ELSE %]<li>[% END %]
>     <a href="/cgi-bin/koha/catalogue/moredetail.pl?biblionumber=[% biblio_object_id | url  %]">Items</a></li>
>     [% IF ( CAN_user_reserveforothers ) %]
>-    [% IF ( holdsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio_object_id | url  %]">Holds ([% Biblio.HoldsCount( biblio_object_id ) %])</a></li>
>+    [% IF ( holdsview ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% biblio_object_id | url  %]">Holds[% IF (Biblio.HoldsCount) %] ([% Biblio.HoldsCount( biblio_object_id ) %])[% END %]</a></li>
>     [% END %]
>     [% IF ( EasyAnalyticalRecords ) %][% IF ( analyze ) %]<li class="active">[% ELSE %]<li>[% END %]<a href="/cgi-bin/koha/catalogue/detail.pl?biblionumber=[% biblio_object_id | url  %]&amp;analyze=1">Analytics</a></li>[% END %]
> 
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>index 3e8b8b1..07fc85b 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/results.tt
>@@ -587,7 +587,7 @@ var holdForPatron = function () {
>                             [% IF ( SEARCH_RESULT.norequests ) %]
>                                 <span class="noholdstext">No holds allowed</span>
>                             [% ELSE %]
>-                                <a id="reserve_[% SEARCH_RESULT.biblionumber %]" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Holds ([% SEARCH_RESULT.holdscount %])</a>
>+                                <a id="reserve_[% SEARCH_RESULT.biblionumber %]" href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]">Holds [% IF (SEARCH_RESULT.holdscount) %]([% SEARCH_RESULT.holdscount %])[% END %]</a>
>                                 [% IF ( holdfor ) %] <span class="holdforlink">| <a href="/cgi-bin/koha/reserve/request.pl?biblionumber=[% SEARCH_RESULT.biblionumber %]&amp;findborrower=[% holdfor_cardnumber %]">Place hold for [% holdfor_firstname %] [% holdfor_surname %] ([% holdfor_cardnumber %])</a></span>[% END %]
>                             [% END %]
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 14876: 53402 | 53465 | 54578 | 55889 | 55892 | 55910 | 56082 | 57000 | 58013 | 58153