Attachment 56117 Details for Bug 17420 – Bug 17420 - record export fails when itemtype on biblio

[patch] Bug 17420 - record export fails when itemtype on biblio

Bug-17420---record-export-fails-when-itemtype-on-b.patch (text/plain), 1.66 KB, created by Fridolin Somers on 2016-10-10 14:53:34 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Fridolin Somers

Created: 2016-10-10 14:53:34 UTC

Size: 1.66 KB

patch

obsolete

>From 9cd8c1c2b26cb45a8e55b464260a3509ca5a0203 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Mon, 10 Oct 2016 16:46:04 +0200
>Subject: [PATCH] Bug 17420 - record export fails when itemtype on biblio
>
>In Tools, Export data, you can export with a filter on item type.
>When item type is on biblio record, you get the error :
>export.pl: DBIx::Class::ResultSet::next(): Unknown column 'biblioitems.itemtype' in 'where clause' at /home/koha/src/Koha/Objects.pm line 150
>
>Looks like its because this code use to be a SQL Select and is now a DBIx call :
>                          C4::Context->preference('item-level_itypes')
>                            ? ( 'items.itype' => $itemtype )
>                            : ( 'me.itemtype' => $itemtype )
>
>This patch corrects by using "me.itemtype"
>
>Test plan :
>- Use syspref item-level_itypes = biblio record
>- Go to Tools > Export data : /cgi-bin/koha/tools/export.pl
>- Select an item type
>- Click on "Export biblio records"
>=> Without patch you get an empty file and error 500 in logs
>=> With patch you get a correct export file
>---
> tools/export.pl | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/tools/export.pl b/tools/export.pl
>index c585d90..03792c3 100755
>--- a/tools/export.pl
>+++ b/tools/export.pl
>@@ -139,7 +139,7 @@ if ( $op eq "export" ) {
>                         ?
>                           C4::Context->preference('item-level_itypes')
>                             ? ( 'items.itype' => $itemtype )
>-                            : ( 'biblioitems.itemtype' => $itemtype )
>+                            : ( 'me.itemtype' => $itemtype )
>                         : ()
>                     ),
> 
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17420: 56117 | 56118 | 57269 | 57405 | 57406 | 57442 | 57443