Bugzilla – Attachment 56120 Details for
Bug 17419
Fix more confusion between smsalertnumber and mobile
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl
Bug-17419-Fix-smsalertnumber-and-mobile-confusion-.patch (text/plain), 2.17 KB, created by
Marc Véron
on 2016-10-10 19:12:25 UTC
(
hide
)
Description:
Bug 17419: Fix smsalertnumber and mobile confusion in moremember.pl
Filename:
MIME Type:
Creator:
Marc Véron
Created:
2016-10-10 19:12:25 UTC
Size:
2.17 KB
patch
obsolete
>From e2a6d0fc76c3c027a6bdb98ee593a31c19840ad9 Mon Sep 17 00:00:00 2001 >From: Lari Taskula <lari.taskula@jns.fi> >Date: Mon, 10 Oct 2016 17:06:07 +0300 >Subject: [PATCH] Bug 17419: Fix smsalertnumber and mobile confusion in > moremember.pl > >members/moremember.pl will set mobile number as smsalertnumber in template if >smsalertnumber is not defined. This will cause incorrect display for SMS number >in patron's Details-tab. This confusion between smsalertnumber and mobile is >already fixed in Bug 14683, but members/moremember.pl was not fixed yet. > >This is a minor issue since it won't occur for manually added new patrons due to >fixes already pushed in Bug 14683, but in case patron's smsalertnumber is null >in database, this bug can be replicated: > >To test: >1. Set EnhancedMessagingPreferences to "Allow" and make sure SMSSendDriver > has been set. >2. Add a new patron, give it a mobile/other phone number. >3. Run a SQL query: > update koha.borrowers set smsalertnumber=NULL where borrowernumber=XXX; > (replace XXX with your new patron's borrowernumber) >4. Go to patron's details tab and observe that SMS number shows the mobile/ > other phone you provided earlier. >5. Apply patch. >6. Refresh patron's details tab. >7. Observe that smsalertnumber is now empty, as it should be. > >Followed test plan, works as expected. >Signed-off-by: Marc <veron@veron.ch> >--- > members/moremember.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/moremember.pl b/members/moremember.pl >index 00e2600..2223a9d 100755 >--- a/members/moremember.pl >+++ b/members/moremember.pl >@@ -315,7 +315,7 @@ if (C4::Context->preference('EnhancedMessagingPreferences')) { > C4::Form::MessagingPreferences::set_form_values({ borrowernumber => $borrowernumber }, $template); > $template->param(messaging_form_inactive => 1); > $template->param(SMSSendDriver => C4::Context->preference("SMSSendDriver")); >- $template->param(SMSnumber => defined $data->{'smsalertnumber'} ? $data->{'smsalertnumber'} : $data->{'mobile'}); >+ $template->param(SMSnumber => $data->{'smsalertnumber'}); > $template->param(TalkingTechItivaPhone => C4::Context->preference("TalkingTechItivaPhoneNotification")); > } > >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17419
:
56106
|
56120
|
57669