Bugzilla – Attachment 56134 Details for
Bug 17423
patronimage.pl permission is too restrictive
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17423 - patronimage.pl permission is too restrictive
Bug-17423---patronimagepl-permission-is-too-restri.patch (text/plain), 1.29 KB, created by
Fridolin Somers
on 2016-10-11 08:07:52 UTC
(
hide
)
Description:
Bug 17423 - patronimage.pl permission is too restrictive
Filename:
MIME Type:
Creator:
Fridolin Somers
Created:
2016-10-11 08:07:52 UTC
Size:
1.29 KB
patch
obsolete
>From 3f9f9ddb558f8c9afb62c17e6881cecc09139402 Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Tue, 11 Oct 2016 10:00:56 +0200 >Subject: [PATCH] Bug 17423 - patronimage.pl permission is too restrictive > >Bug 14566 added the permission "borrowers" on patronimage.pl. >This perm is too restrictive because circulation pages also uses this page. > >I propose to simply use "catalogue" perm. > >Test plan >- Set an image to borrower xx >- Create a user with only catalogue permission >- Log with this user >- Go to page (replace xx by borrower number) : /cgi-bin/koha/members/patronimage.pl?borrowernumber=xx >=> Without patch you get 403 error >=> With patch you get the image >--- > members/patronimage.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/patronimage.pl b/members/patronimage.pl >index b833978..f3534c3 100755 >--- a/members/patronimage.pl >+++ b/members/patronimage.pl >@@ -48,7 +48,7 @@ This script, when called from within HTML and passed a valid patron borrowernumb > > =cut > >-my ($status, $cookie, $sessionID) = check_api_auth($query, { borrowers => 1} ); >+my ($status, $cookie, $sessionID) = check_api_auth($query, { catalogue => 1 } ); > > unless ( $status eq 'ok' ) { > print $query->header(-type => 'text/plain', -status => '403 Forbidden'); >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17423
:
56134
|
56136
|
56150
|
56166
|
56289