Bugzilla – Attachment 56139 Details for
Bug 17226
Improve AUTOLOAD of Koha::Object
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17226: Make Koha::Object->get_column available
Bug-17226-Make-KohaObject-getcolumn-available.patch (text/plain), 1.53 KB, created by
Kyle M Hall (khall)
on 2016-10-11 09:00:48 UTC
(
hide
)
Description:
Bug 17226: Make Koha::Object->get_column available
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-10-11 09:00:48 UTC
Size:
1.53 KB
patch
obsolete
>From aa3aa239d8b9c762ef153badac0719b7bcc69cb6 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 30 Aug 2016 16:22:53 +0100 >Subject: [PATCH] Bug 17226: Make Koha::Object->get_column available > >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> >--- > Koha/Object.pm | 2 +- > t/db_dependent/Koha/Object.t | 7 ++++++- > 2 files changed, 7 insertions(+), 2 deletions(-) > >diff --git a/Koha/Object.pm b/Koha/Object.pm >index a82f80e..cf55089 100644 >--- a/Koha/Object.pm >+++ b/Koha/Object.pm >@@ -237,7 +237,7 @@ sub AUTOLOAD { > } > } > >- my @known_methods = qw( is_changed id in_storage ); >+ my @known_methods = qw( is_changed id in_storage get_column ); > > carp "The method $method is not covered by tests or does not exist!" and return unless grep {/^$method$/} @known_methods; > >diff --git a/t/db_dependent/Koha/Object.t b/t/db_dependent/Koha/Object.t >index a8eaded..4b0a1c4 100755 >--- a/t/db_dependent/Koha/Object.t >+++ b/t/db_dependent/Koha/Object.t >@@ -17,7 +17,7 @@ > > use Modern::Perl; > >-use Test::More tests => 5; >+use Test::More tests => 6; > use Test::Warn; > > use C4::Context; >@@ -84,4 +84,9 @@ subtest 'id' => sub { > is( $patron->id, $patron->borrowernumber ); > }; > >+subtest 'get_column' => sub { >+ plan tests => 1; >+ my $patron = Koha::Patron->new({categorycode => $categorycode, branchcode => $branchcode })->store; >+ is( $patron->get_column('borrowernumber'), $patron->borrowernumber, 'get_column should retrieve the correct value' ); >+}; > 1; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17226
:
55037
|
55038
|
55203
|
55204
|
56138
| 56139 |
56140