Attachment 56154 Details for Bug 17389 – [PASSED QA] Bug 17389: Clear logs

[patch] [PASSED QA] Bug 17389: Clear logs

PASSED-QA-Bug-17389-Clear-logs.patch (text/plain), 1.51 KB, created by Katrin Fischer on 2016-10-11 09:46:02 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Katrin Fischer

Created: 2016-10-11 09:46:02 UTC

Size: 1.51 KB

patch

obsolete

>From c5228daa2a13c5ce0774ad8eb7296f10e5f5ee9f Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Mon, 3 Oct 2016 15:23:39 +0100
>Subject: [PATCH] [PASSED QA] Bug 17389: Clear logs
>
>Logs are full of:
>Use of uninitialized value in substitution (s///) at
>C4/ImportExportFramework.pm line 282.
>Use of uninitialized value in concatenation (.) or string at
>C4/ImportExportFramework.pm line 283.
>
>Some field are NULL in DB, we need to init the value to an empty string
>to avoid these warnings.
>
>Note: This fix is not related to the original bug
>Signed-off-by: Hector Castro <hector.hecaxmmx@gmail.com>
>Warnings avoided
>
>Signed-off-by: Katrin Fischer  <katrin.fischer@bsz-bw.de>
>---
> C4/ImportExportFramework.pm | 7 ++++---
> 1 file changed, 4 insertions(+), 3 deletions(-)
>
>diff --git a/C4/ImportExportFramework.pm b/C4/ImportExportFramework.pm
>index 2d3bf07..bc02cca 100644
>--- a/C4/ImportExportFramework.pm
>+++ b/C4/ImportExportFramework.pm
>@@ -278,9 +278,10 @@ sub _export_table_csv
>         $sth->execute($frameworkcode);
>         my $data;
>         while (my $hashRef = $sth->fetchrow_hashref) {
>-            for (@fields) {
>-                $hashRef->{$_} =~ s/[\r\n]//g;
>-                $$strCSV .= '"' . $hashRef->{$_} . '",';
>+            for my $field (@fields) {
>+                my $value = $hashRef->{$field} // q||;
>+                $value =~ s/[\r\n]//g;
>+                $$strCSV .= '"' . $value . '",';
>             }
>             chop $$strCSV;
>             $$strCSV .= chr(10);
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17389: 55975 | 55977 | 55983 | 55984 | 56153 | 56154