Bugzilla – Attachment 56307 Details for
Bug 11217
The # in accountlines descriptions makes them un-writeoffable
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 11217: The # in accountlines descriptions makes them un-writeoffable
Bug-11217-The--in-accountlines-descriptions-makes-.patch (text/plain), 1.80 KB, created by
Nick Clemens (kidclamp)
on 2016-10-13 08:03:15 UTC
(
hide
)
Description:
Bug 11217: The # in accountlines descriptions makes them un-writeoffable
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-10-13 08:03:15 UTC
Size:
1.80 KB
patch
obsolete
>From 9c4baf4453f24b995154da95abfb0c294cb99c81 Mon Sep 17 00:00:00 2001 >From: Marc <veron@veron.ch> >Date: Fri, 7 Oct 2016 11:03:45 +0200 >Subject: [PATCH] Bug 11217: The # in accountlines descriptions makes them > un-writeoffable > >This patch adds escaping to url params in mambers/pay.pl > >To test: >- Apply patch >- Go to Home > Patrons > Manual invoice and create an invoice with a > description containing a # >- Go to tab "Pay fines" >- Write off the fine >Expected result: Fine is written off and does no longer display in pay tab. > >Signed-off-by: Claire Gravely <claire_gravely@hotmail.com> > >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > members/pay.pl | 5 +++-- > 1 file changed, 3 insertions(+), 2 deletions(-) > >diff --git a/members/pay.pl b/members/pay.pl >index 6ee652c..bfca78b 100755 >--- a/members/pay.pl >+++ b/members/pay.pl >@@ -43,6 +43,7 @@ use C4::Members::Attributes qw(GetBorrowerAttributes); > use Koha::Patron::Images; > > use Koha::Patron::Categories; >+use URI::Escape; > > our $input = CGI->new; > >@@ -174,8 +175,8 @@ sub redirect_to_paycollect { > $redirect .= get_for_redirect( 'amount', "amount$line_no", 1 ); > $redirect .= > get_for_redirect( 'amountoutstanding', "amountoutstanding$line_no", 1 ); >- $redirect .= get_for_redirect( 'description', "description$line_no", 0 ); >- $redirect .= get_for_redirect( 'title', "title$line_no", 0 ); >+ $redirect .= uri_escape_utf8( get_for_redirect( 'description', "description$line_no", 0 ) ); >+ $redirect .= uri_escape_utf8( get_for_redirect( 'title', "title$line_no", 0 ) ); > $redirect .= get_for_redirect( 'itemnumber', "itemnumber$line_no", 0 ); > $redirect .= get_for_redirect( 'notify_id', "notify_id$line_no", 0 ); > $redirect .= get_for_redirect( 'notify_level', "notify_level$line_no", 0 ); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 11217
:
56078
|
56304
| 56307