Bugzilla – Attachment 5637 Details for
Bug 6938
The "Subscription History" public and private note fields have gone missing
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 6938 - replace two subscription fields that were incorrectly removed
Bug-6938---replace-two-subscription-fields-that-we.patch (text/plain), 4.70 KB, created by
Robin Sheat
on 2011-09-29 05:08:14 UTC
(
hide
)
Description:
Bug 6938 - replace two subscription fields that were incorrectly removed
Filename:
MIME Type:
Creator:
Robin Sheat
Created:
2011-09-29 05:08:14 UTC
Size:
4.70 KB
patch
obsolete
>From 993a7df855d7bdbfa35d116e1e76d5fdd432be04 Mon Sep 17 00:00:00 2001 >From: Robin Sheat <robin@catalyst.net.nz> >Date: Thu, 29 Sep 2011 18:05:49 +1300 >Subject: [PATCH] Bug 6938 - replace two subscription fields that were incorrectly removed > >The "Note for OPAC" and "Note for staff" fields in subscriptions were >removed, but they are their own fields in the database and display in >other places too. This patch puts them back so that they can once again >be edited. >--- > .../prog/en/modules/serials/subscription-add.tt | 41 +++++++++++-------- > .../prog/en/modules/serials/subscription-detail.tt | 2 + > 2 files changed, 26 insertions(+), 17 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >index f21e72d..40e1ebe 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-add.tt >@@ -1077,25 +1077,32 @@ $(document).ready(function() { > <div><h3 style="display:inline">Subscription history</h3> <a href="#" id="cancel_manual_history">[cancel manual history]</a></div> > <p>Hint: you can update the serial history manually. This can be useful for an old subscription or to clean the existing history. Modify these fields with care, as future serial receive will continue to update them automatically.</p> > <fieldset class="rows"> >- <ol> >- <li> >- <label for="histstartdate">Subscription start date</label> >- <input type="text" name="histstartdate" id="histstartdate" value="[% histstartdate %]" /><div class="hint"> (start date of the 1st subscription)</div> >- </li> >- <li> >- <label for="histenddate">Subscription end date</label> >- <input type="text" name="histenddate" id="histenddate" value="[% histenddate %]" /> <div class="hint">(if empty, subscription is still active)</div> >- </li> >- <li> >+ <ol> >+ <li> >+ <label for="histstartdate">Subscription start date</label> >+ <input type="text" name="histstartdate" id="histstartdate" value="[% histstartdate %]" /><div class="hint"> (start date of the 1st subscription)</div> >+ </li> >+ <li> >+ <label for="histenddate">Subscription end date</label> >+ <input type="text" name="histenddate" id="histenddate" value="[% histenddate %]" /> <div class="hint">(if empty, subscription is still active)</div> >+ </li> >+ <li> > <label for="recievedlist">Received issues</label> >- <textarea name="recievedlist" id="recievedlist" cols="60" rows="5">[% recievedlist %]</textarea> >- </li> >- <li> >+ <textarea name="recievedlist" id="recievedlist" cols="60" rows="5">[% recievedlist %]</textarea> >+ </li> >+ <li> > <label for="missinglist">Missing issues</label> >- <textarea name="missinglist" id="missinglist" cols="60" rows="5">[% missinglist %]</textarea> >- </li> >- <li> >- </ol> >+ <textarea name="missinglist" id="missinglist" cols="60" rows="5">[% missinglist %]</textarea> >+ </li> >+ <li> >+ <label for="opacnote">Note for OPAC</label> >+ <textarea name="opacnote" id="opacnote" cols="60" rows="5">[% opacnote %]</textarea> >+ </li> >+ <li> >+ <label for="librariannote">Note for staff</label> >+ <textarea name="librariannote" id="librariannote" cols="60" rows="5">[% librariannote %]</textarea> >+ </li> >+ </ol> > </fieldset> > <fieldset class="action"><input type="submit" value="Save subscription history" /></fieldset> > </div> >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >index bba6a2e..097c25e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/serials/subscription-detail.tt >@@ -353,6 +353,8 @@ function popup(subscriptionid) { > <tr><td><label>Missing issues</label></td><td>[% missinglist %]</td></tr> > <tr><td><label>Nonpublic note</label></td><td>[% internalnotes %]</td></tr> > <tr><td><label>Public note</label></td><td>[% notes %]</td></tr> >+ <tr><td><label>History staff note</label></td><td>[% librariannote %]</td></tr> >+ <tr><td><label>History OPAC note</label></td><td>[% opacnote %]</td></tr> > </table> > </div> > >-- >1.7.4.1
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 6938
:
5637
|
5860