Bugzilla – Attachment 56414 Details for
Bug 16358
Rancor - Deleting records when Rancor is enabled just opens them
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 16358: Do not redirect to the editor when deleting records
Bug-16358-Do-not-redirect-to-the-editor-when-delet.patch (text/plain), 1.88 KB, created by
Kyle M Hall (khall)
on 2016-10-13 15:11:20 UTC
(
hide
)
Description:
Bug 16358: Do not redirect to the editor when deleting records
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-10-13 15:11:20 UTC
Size:
1.88 KB
patch
obsolete
>From cb21b04bfcf02e2ce800ce3909f3d45e6f07b9cb Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 13 Sep 2016 15:03:55 +0100 >Subject: [PATCH] Bug 16358: Do not redirect to the editor when deleting > records > >The "Delete record" button goes to addbiblio.pl?op=delete, which >incorrectly redirects to Rancor when selected. > >Test plan: >0/ Enable EnableAdvancedCatalogingEditor >1/ Edit a record >2/ Switch to the Advanced editor >3/ click on "View the record" >4/ Delete the record >=> Without this patch you are redirected to the editor >=> With this patch you are redirected to the advanced search > >Signed-off-by: Mirko Tietgen <mirko@abunchofthings.net> > >Signed-off-by: Kyle M Hall <kyle@bywatersolutions.com> >--- > cataloguing/addbiblio.pl | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/cataloguing/addbiblio.pl b/cataloguing/addbiblio.pl >index a1f7208..7c8b66f 100755 >--- a/cataloguing/addbiblio.pl >+++ b/cataloguing/addbiblio.pl >@@ -736,11 +736,12 @@ if ($frameworkcode eq 'FA'){ > 'stickyduedate' => $fa_stickyduedate, > 'duedatespec' => $fa_duedatespec, > ); >-} elsif ( C4::Context->preference('EnableAdvancedCatalogingEditor') && $input->cookie( 'catalogue_editor_' . $loggedinuser ) eq 'advanced' && !$breedingid ) { >+} elsif ( $op ne "delete" && C4::Context->preference('EnableAdvancedCatalogingEditor') && $input->cookie( 'catalogue_editor_' . $loggedinuser ) eq 'advanced' && !$breedingid ) { > # Only use the advanced editor for non-fast-cataloging. > # breedingid is not handled because those would only come off a Z39.50 > # search initiated by the basic editor. > print $input->redirect( '/cgi-bin/koha/cataloguing/editor.pl' . ( $biblionumber ? ( '#catalog/' . $biblionumber ) : '' ) ); >+ exit; > } > > my $frameworkcodeloop = Koha::BiblioFrameworks->search({}, { order_by => ['frameworktext'] }); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16358
:
55533
|
56305
| 56414