Bugzilla – Attachment 56541 Details for
Bug 17367
Showing all items must keep show holdings tab in OPAC details
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17367 - Showing all items must keep show holdings tab in OPAC details
Bug-17367---Showing-all-items-must-keep-show-holdi.patch (text/plain), 2.04 KB, created by
Nick Clemens (kidclamp)
on 2016-10-14 14:01:30 UTC
(
hide
)
Description:
Bug 17367 - Showing all items must keep show holdings tab in OPAC details
Filename:
MIME Type:
Creator:
Nick Clemens (kidclamp)
Created:
2016-10-14 14:01:30 UTC
Size:
2.04 KB
patch
obsolete
>From 3a32e95f886fb43d8f36ca0c1a7843b2dad5ac9b Mon Sep 17 00:00:00 2001 >From: Fridolin Somers <fridolin.somers@biblibre.com> >Date: Wed, 28 Sep 2016 14:49:32 +0200 >Subject: [PATCH] Bug 17367 - Showing all items must keep show holdings tab in > OPAC details > >In OPAC details page, when record as too many items (depending on syspref OpacMaxItemsToDisplay), they are not displayed in holdings tab. >You can click on link "Click here to view them all" to show them : page reloads with a new arg viewallitems=1. >Also you can choose which tab is shown by default using syspref opacSerialDefaultTab. > >The bug is that when default tab is not holdings, clicking on link to show all items will show another tab. So one must reclick on holings tab to see all items. > >This patch corrects by forcing holdings tab when arg viewallitems is defined. > >Test plan : >- Create a serial record with more items than syspref OpacMaxItemsToDisplay (or decrease this syspref) >- Select "Subscriptions tab" for syspref opacSerialDefaultTab >- Go to opac details on this record : /cgi-bin/koha/opac-detail.pl?biblionumber=xxx >=> You see Subscriptions tab selected >- Click on Holdings tab >=> You see no items but a link "Click here to view them all" >- Click on this link >=> Without patch you see Subscriptions tab selected >=> Wih patch you see Holdings tab selected and the items > >Signed-off-by: Juliette <juliette.levast@iepg.fr> >Signed-off-by: Nick Clemens <nick@bywatersolutions.com> >--- > opac/opac-detail.pl | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/opac/opac-detail.pl b/opac/opac-detail.pl >index 6a68a52..5d0eeff 100755 >--- a/opac/opac-detail.pl >+++ b/opac/opac-detail.pl >@@ -1134,6 +1134,8 @@ if ( C4::Context->preference("IDREF") ) { > # the user wants, and what's available for display > my $opac_serial_default = C4::Context->preference('opacSerialDefaultTab'); > my $defaulttab = >+ $viewallitems >+ ? 'holdings' : > $opac_serial_default eq 'subscriptions' && $subscriptionsnumber > ? 'subscriptions' : > $opac_serial_default eq 'serialcollection' && @serialcollections > 0 >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17367
:
55886
|
56193
| 56541