Attachment 56629 Details for Bug 17444 – Bug 17444: Enable exporting by time, not only date

[patch] Bug 17444: Enable exporting by time, not only date

Bug-17444-Enable-exporting-by-time-not-only-date.patch (text/plain), 2.56 KB, created by Jonathan Druart on 2016-10-18 16:25:55 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-10-18 16:25:55 UTC

Size: 2.56 KB

patch

obsolete

>From 08b92d1555373166f089a4e84f4458f88fe3e106 Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Tue, 15 Dec 2015 12:07:38 +0100
>Subject: [PATCH] Bug 17444: Enable exporting by time, not only date
>
>Test plan:
>1) Apply the patch
>2) Edit a biblio
>3) run export_records.pl with date time few minutes in the past
>for example: --format=xml --record-type=bibs --date="2016-10-14 10:00:05" --filename="koha.xml"
>4) look in the file and cofirm that the right record was exported
>5) Try the same but with time after the biblio was edited, it shouldn't be exported
>
>Signed-off-by: radiuscz <radek.siman@centrum.cz>
>
>Bug 17444: Follow-up, don't change the name of parameter "date"
>
>Signed-off-by: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>---
> misc/export_records.pl | 12 ++++++------
> 1 file changed, 6 insertions(+), 6 deletions(-)
>
>diff --git a/misc/export_records.pl b/misc/export_records.pl
>index 59d0dfe..83d8a7b 100755
>--- a/misc/export_records.pl
>+++ b/misc/export_records.pl
>@@ -95,7 +95,7 @@ open STDOUT, '>', $filename if $filename;
> 
> my @record_ids;
> 
>-$timestamp = ($timestamp) ? output_pref({ dt => dt_from_string($timestamp), dateformat => 'iso', dateonly => 1, }): '';
>+$timestamp = ($timestamp) ? output_pref({ dt => dt_from_string($timestamp), dateformat => 'iso', dateonly => 0, }): '';
> 
> if ( $record_type eq 'bibs' ) {
>     if ( $timestamp ) {
>@@ -219,7 +219,7 @@ export records - This script exports record (biblios or authorities)
> 
> =head1 SYNOPSIS
> 
>-export_records.pl [-h|--help] [--format=format] [--date=date] [--record-type=TYPE] [--dont_export_items] [--deleted_barcodes] [--clean] [--id_list_file=PATH] --filename=outputfile
>+export_records.pl [-h|--help] [--format=format] [--date=datetime] [--record-type=TYPE] [--dont_export_items] [--deleted_barcodes] [--clean] [--id_list_file=PATH] --filename=outputfile
> 
> =head1 OPTIONS
> 
>@@ -235,10 +235,10 @@ Print a brief help message.
> 
> =item B<--date>
> 
>- --date=DATE            DATE should be entered as the 'dateformat' syspref is
>-                        set (dd/mm/yyyy for metric, yyyy-mm-dd for iso,
>-                        mm/dd/yyyy for us) records exported are the ones that
>-                        have been modified since DATE.
>+ --date=DATETIME        DATETIME should be entered as the 'dateformat' syspref is
>+                        set (dd/mm/yyyy[ hh:mm:ss] for metric, yyyy-mm-dd[ hh:mm:ss] for iso,
>+                        mm/dd/yyyy[ hh:mm:ss] for us) records exported are the ones that
>+                        have been modified since DATETIME.
> 
> =item B<--record-type>
> 
>-- 
>2.8.1

Actions: View | Diff | Splinter Review

Attachments on bug 17444: 56447 | 56496 | 56574 | 56629