Attachment 56704 Details for Bug 17477 – Bug 17477: Duplicating a subfield yields an empty subfield tag

[patch] Bug 17477: Duplicating a subfield yields an empty subfield tag

Bug-17477-Duplicating-a-subfield-yields-an-empty-s.patch (text/plain), 1.47 KB, created by Tomás Cohen Arazi (tcohen) on 2016-10-20 15:19:54 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Tomás Cohen Arazi (tcohen)

Created: 2016-10-20 15:19:54 UTC

Size: 1.47 KB

patch

obsolete

>From 5da5b7ef47dc1112d2aa502c8999978170b43576 Mon Sep 17 00:00:00 2001
>From: Hector Castro <hector.hecaxmmx@gmail.com>
>Date: Thu, 20 Oct 2016 08:57:46 -0600
>Subject: [PATCH] Bug 17477: Duplicating a subfield yields an empty subfield
> tag
>
>The problem only when clone a textareas in 5XX
>
>Steps to reproduce error:
>- On the cataloging screen (basic screen), create a new record
>- Go to the 5xx fields
>- Put something on the 521$a subfield or other textareas (e.g. 520$u or
> 583$x)
>- Clone the subfield
>=> FAIL: The subfield correctly doesn't include the original data,
>BUT it doesn't have the subtield tag either.
>
>- Apply patch
>- Clean cache browser and reload page
>- Repeat steps above
>- Verify that works as expected
>
>Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io>
>---
> koha-tmpl/intranet-tmpl/prog/js/cataloging.js | 1 +
> 1 file changed, 1 insertion(+)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>index 6f55930..ee03961 100644
>--- a/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>+++ b/koha-tmpl/intranet-tmpl/prog/js/cataloging.js
>@@ -288,6 +288,7 @@ function CloneSubfield(index, advancedMARCEditor){
>         id_input = textareas[i].getAttribute('id')+new_key;
>         textareas[i].setAttribute('id',textareas[i].getAttribute('id')+new_key);
>         textareas[i].setAttribute('name',textareas[i].getAttribute('name')+new_key);
>+        linkid = id_input;
>     }
> 
>     // Handle click event on buttonDot for plugin
>-- 
>2.7.4

Actions: View | Diff | Splinter Review

Attachments on bug 17477: 56697 | 56700 | 56704 | 56722