Bugzilla – Attachment 56724 Details for
Bug 17428
REST API: CRUD endpoint for cities
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
QA Followup - Fix failing test
QA-Followup---Fix-failing-test.patch (text/plain), 1.21 KB, created by
Martin Renvoize (ashimema)
on 2016-10-21 15:47:06 UTC
(
hide
)
Description:
QA Followup - Fix failing test
Filename:
MIME Type:
Creator:
Martin Renvoize (ashimema)
Created:
2016-10-21 15:47:06 UTC
Size:
1.21 KB
patch
obsolete
>From 963b02f2899c88c12fe6ebbcdb628b5a0e18ea72 Mon Sep 17 00:00:00 2001 >From: Martin Renvoize <martin.renvoize@ptfs-europe.com> >Date: Fri, 21 Oct 2016 15:41:52 +0000 >Subject: [PATCH] QA Followup - Fix failing test > >Failing test case is due to random array order, so the best we can do is >check for the presence of the errors key. > >https://bugs.koha-community.org/show_bug.cgi?id=17428 >--- > t/db_dependent/api/v1/cities.t | 9 +-------- > 1 file changed, 1 insertion(+), 8 deletions(-) > >diff --git a/t/db_dependent/api/v1/cities.t b/t/db_dependent/api/v1/cities.t >index c0a0c3e..e6e13c6 100644 >--- a/t/db_dependent/api/v1/cities.t >+++ b/t/db_dependent/api/v1/cities.t >@@ -190,14 +190,7 @@ subtest 'add() tests' => sub { > $tx->req->cookies( > { name => 'CGISESSID', value => $authorized_session_id } ); > $tx->req->env( { REMOTE_ADDR => $remote_address } ); >- $t->request_ok($tx)->status_is(400)->json_is( >- "/errors" => [ >- { >- message => "Read-only.", >- path => "/body/cityid" >- } >- ] >- ); >+ $t->request_ok($tx)->status_is(400)->json_has('/errors'); > > # Authorized attempt to create with existing id > $city->{cityid} = $cityid; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17428
:
56189
|
56190
|
56191
|
56226
|
56227
|
56228
|
56261
|
56314
|
56501
|
56544
|
56545
|
56548
|
56553
|
56554
|
56555
|
56556
|
56557
|
56558
|
56559
|
56724
|
56741
|
56800
|
56801
|
56802
|
56803
|
56804
|
56807
|
56808
|
56809
|
56810
|
56811
|
56812