Bugzilla – Attachment 56734 Details for
Bug 17292
Use of DBIx in updatedatabase.pl broke upgrade (from bug 12375)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17292 Follow-up, fix typos
Bug-17292-Follow-up-fix-typos.patch (text/plain), 1.64 KB, created by
Frédéric Demians
on 2016-10-22 10:35:19 UTC
(
hide
)
Description:
Bug 17292 Follow-up, fix typos
Filename:
MIME Type:
Creator:
Frédéric Demians
Created:
2016-10-22 10:35:19 UTC
Size:
1.64 KB
patch
obsolete
>From 8ff0d2fe586a774af234f4f65670fb3dd720bd8f Mon Sep 17 00:00:00 2001 >From: =?UTF-8?q?Fr=C3=A9d=C3=A9ric=20Demians?= <f.demians@tamil.fr> >Date: Sat, 22 Oct 2016 12:41:21 +0200 >Subject: [PATCH] Bug 17292 Follow-up, fix typos >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >- wrong assignation >- reference to 'serials' table rather than 'serial' > >Signed-off-by: Frédéric Demians <f.demians@tamil.fr> >--- > installer/data/mysql/updatedatabase.pl | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 5e4be32..86232d4 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -11471,13 +11471,12 @@ if ( C4::Context->preference("Version") < TransformToNum($DBversion) ) { > > my $sth2 = $dbh->prepare("SELECT * FROM subscription_numberpatterns WHERE id = ?"); > >- my $sth3 = $dbh->prepare("UPDATE serials SET serialseq_x = ?, serialseq_y = ?, serialseq_z = ? WHERE serialid = ?"); >+ my $sth3 = $dbh->prepare("UPDATE serial SET serialseq_x = ?, serialseq_y = ?, serialseq_z = ? WHERE serialid = ?"); > > foreach my $subscription ( $sth->fetchrow_hashref() ) { > next if !defined($subscription); >- my $number_pattern = $subscription->numberpattern(); > $sth2->execute( $subscription->{numberpattern} ); >- $number_pattern = $sth2->fetchrow_hashref(); >+ my $number_pattern = $sth2->fetchrow_hashref(); > > my $numbering_method = $number_pattern->{numberingmethod}; > # Get all the data between the enumeration values, we need >-- >2.9.2
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17292
:
55502
|
55672
|
55673
|
55674
|
55861
|
55862
| 56734