Bugzilla – Attachment 5678 Details for
Bug 5263
Add support for including fields from the ISSUES table in advanced due notices
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Follow up Patch
0001-Bug-5236-Followup-items-table-information-being-keye.patch (text/plain), 1.58 KB, created by
Ian Walls
on 2011-10-03 14:50:51 UTC
(
hide
)
Description:
Follow up Patch
Filename:
MIME Type:
Creator:
Ian Walls
Created:
2011-10-03 14:50:51 UTC
Size:
1.58 KB
patch
obsolete
>From 2331a2d8e0052950334d25cbdc58ec01f6d7fbb8 Mon Sep 17 00:00:00 2001 >From: Ian Walls <ian.walls@bywatersolutions.com> >Date: Mon, 3 Oct 2011 10:45:59 -0400 >Subject: [PATCH] Bug 5236 Followup: items table information being keyed by biblionumber instead! > >This patch fixes an error with bugfix 5236; any item-table information in the PREDUE letter >was being parsed with biblionumber as the key, instead of itemnumber. Unless itemnumber == biblionumber, >this will ALWAYS return the wrong information. > >I've moved the item table parsing line to within the if ($itemnumber) conditional check, and replaced >the key to use the itemnumber instead of the biblionumber. >--- > misc/cronjobs/advance_notices.pl | 2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) > >diff --git a/misc/cronjobs/advance_notices.pl b/misc/cronjobs/advance_notices.pl >index 3ca4835..1fa358f 100755 >--- a/misc/cronjobs/advance_notices.pl >+++ b/misc/cronjobs/advance_notices.pl >@@ -349,11 +349,11 @@ sub parse_letter { > } > if ( $params->{'itemnumber'} ) { > C4::Letters::parseletter( $params->{'letter'}, 'issues', $params->{'itemnumber'} ); >+ C4::Letters::parseletter( $params->{'letter'}, 'items', $params->{'itemnumber'} ); > } > if ( $params->{'biblionumber'} ) { > C4::Letters::parseletter( $params->{'letter'}, 'biblio', $params->{'biblionumber'} ); > C4::Letters::parseletter( $params->{'letter'}, 'biblioitems', $params->{'biblionumber'} ); >- C4::Letters::parseletter( $params->{'letter'}, 'items', $params->{'biblionumber'} ); > } > > return $params->{'letter'}; >-- >1.7.4.1 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 5263
:
4583
|
4648
| 5678