Attachment 56795 Details for Bug 5260 – Bug 5260: Use post params instead of get to avoid putting op=email in the browser history

[patch] Bug 5260: Use post params instead of get to avoid putting op=email in the browser history

Bug-5260-Use-post-params-instead-of-get-to-avoid-p.patch (text/plain), 2.03 KB, created by Jonathan Druart on 2016-10-24 14:02:52 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-10-24 14:02:52 UTC

Size: 2.03 KB

patch

obsolete

>From 3791e3b60574a1639ad55496ef777ab1c90ae013 Mon Sep 17 00:00:00 2001
>From: Jonathan Druart <jonathan.druart@bugs.koha-community.org>
>Date: Thu, 20 Oct 2016 09:07:34 +0100
>Subject: [PATCH] Bug 5260: Use post params instead of get to avoid putting
> op=email in the browser history
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt | 8 +++++++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>index d4622e7..6a530b1 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt
>@@ -202,7 +202,13 @@
>                         <div class="btn-group"><a href="/cgi-bin/koha/acqui/edi_ean.pl?op=ediorder&amp;basketno=[% basketno %]&amp;booksellerid=[% booksellerid %]" class="btn btn-small" id="ediorderbutton"><i class="fa fa-download"></i> Create EDIFACT order</a></div>
>                         [% END %]
>                         [% IF ( active && books_loop ) %]
>-                        <div class="btn-group"><a href="[% script_name %]?op=email&amp;basketno=[% basketno %]" class="btn btn-small" id="emailvendorbutton"><i class="fa fa-envelope"></i> E-mail order</a></div>
>+                            <div class="btn-group">
>+                                <form action="/cgi-bin/koha/acqui/basket.pl" method="post">
>+                                    <input type="hidden" name="op" value="email" />
>+                                    <input type="hidden" name="basketno" value="[% basketno %]" />
>+                                    <button type="submit" class="btn btn-small" id="emailvendorbutton"><i class="fa fa-envelope"></i> E-mail order</button>
>+                                </form>
>+                            </div>
>                         [% END %]
>                 </div>
> 
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 5260: 2653 | 4067 | 4068 | 4781 | 22171 | 56449 | 56450 | 56483 | 56484 | 56549 | 56550 | 56551 | 56560 | 56561 | 56562 | 56568 | 56679 | 56680 | 56686 | 56687 | 56688 | 56689 | 56705 | 56706 | 56707 | 56708 | 56709 | 56786 | 56787 | 56788 | 56789 | 56790 | 56791 | 56792 | 56793 | 56794 | 56795