Attachment 56831 Details for Bug 16935 – Bug 16935 - launch export_records.pl with deleted_barcodes param fails

[patch] Bug 16935 - launch export_records.pl with deleted_barcodes param fails

Bug-16935---launch-exportrecordspl-with-deletedbar.patch (text/plain), 2.01 KB, created by Jonathan Druart on 2016-10-25 08:00:43 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Jonathan Druart

Created: 2016-10-25 08:00:43 UTC

Size: 2.01 KB

patch

obsolete

>From de46f4c0692c0d56370359a65016759870b73717 Mon Sep 17 00:00:00 2001
>From: Fridolin Somers <fridolin.somers@biblibre.com>
>Date: Wed, 24 Aug 2016 11:44:55 +0200
>Subject: [PATCH] Bug 16935 - launch export_records.pl with deleted_barcodes
> param fails
>
>When launching misc/export_records.pl with this command line :
>
> misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/koha.mrc
>
>You get this error message :
>
>DBD::mysql::db selectall_arrayref failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near '' at line 4 [for Statement " (
>            SELECT DISTINCT barcode
>            FROM deleteditems
>            WHERE deleteditems.biblionumber = ?
>        "] at misc/export_records.pl line 189.
>
>This is because of a '(' after 'q|', looks like a typo.
>Also, this patch removes useless var $q.
>
>Test plan :
>- Delete an item with barcode
>- Without patch, run : misc/export_records.pl --date=`date +%d/%m/%Y` --deleted_barcodes --filename=/tmp/koha.mrc
>=> You get dirty MySQL
>- Without patch, run the same command
>=> No error and the file is generated
>
>Signed-off-by: Nicolas Legrand <nicolas.legrand@bulac.fr>
>
>Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com>
>---
> misc/export_records.pl | 6 ++----
> 1 file changed, 2 insertions(+), 4 deletions(-)
>
>diff --git a/misc/export_records.pl b/misc/export_records.pl
>index 83d8a7b..34b4da3 100755
>--- a/misc/export_records.pl
>+++ b/misc/export_records.pl
>@@ -184,14 +184,12 @@ if ( @record_ids and $id_list_file ) {
> 
> if ($deleted_barcodes) {
>     for my $record_id ( @record_ids ) {
>-        my $q = q|
>-        |;
>-        my $barcode = $dbh->selectall_arrayref(q| (
>+        my $barcode = $dbh->selectall_arrayref(q|
>             SELECT DISTINCT barcode
>             FROM deleteditems
>             WHERE deleteditems.biblionumber = ?
>         |, { Slice => {} }, $record_id );
>-        say $_->{barcode} for @$barcode
>+        say $_->{barcode} for @$barcode;
>     }
> }
> else {
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 16935: 54810 | 56478 | 56831