Bugzilla – Attachment 56834 Details for
Bug 17487
Improper placement of select/clear all in Z39.50/SRU search dialog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17487: Links to "select/clear all" moved below the header tag
Bug-17487-Links-to-selectclear-all-moved-below-the.patch (text/plain), 4.75 KB, created by
Jonathan Druart
on 2016-10-25 08:32:43 UTC
(
hide
)
Description:
Bug 17487: Links to "select/clear all" moved below the header tag
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-10-25 08:32:43 UTC
Size:
4.75 KB
patch
obsolete
>From 104b62196530fad296c7c61d42df140260133ab0 Mon Sep 17 00:00:00 2001 >From: radiuscz <radek.siman@centrum.cz> >Date: Sun, 23 Oct 2016 02:51:53 +0200 >Subject: [PATCH] Bug 17487: Links to "select/clear all" moved below the header > tag > >Test plan: >1) Apply patch >2) Display Z39.50 search dialogs: > - cataloguing / new from Z39.50 > - authorities / new from Z39.50 > - acquisition / new from an external source >3) Select all / Clear all should be placed below "Search targets" header > >https://bugs.koha-community.org/show_bug.cgi?id=17487 > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 3 ++- > .../intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt | 3 ++- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 3 ++- > 3 files changed, 6 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >index 61d9e7f..76f2356 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >@@ -91,8 +91,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <input type="hidden" name="booksellerid" value="[% booksellerid | html %]" /> > </div> > <div class="yui-u second"> >-<h2>Search targets <span style="display: inline; font-size: 70%; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span></h2> >+<h2>Search targets</h2> > <div id="z3950_search_targets_acq"> >+ <span style="display: inline; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> > [% FOREACH serverloo IN serverloop %] > <p> > [% IF ( serverloo.checked ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >index 07e69df..f75501c 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >@@ -90,8 +90,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > </fieldset> > </div> > <div class="yui-g"> >- <h2>Search targets <span style="display: inline; font-size: 70%; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span></h2> >+ <h2>Search targets</h2> > <div id="z3950_search_targets_auth"> >+ <span style="display: inline; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> > [% FOREACH serverloo IN serverloop %] > <p> > [% IF ( serverloo.checked ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index c7bc15a..0dcce14 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -86,8 +86,9 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <input type="hidden" name="frameworkcode" value="[% frameworkcode | html %]" /> > </div> > <div class="yui-g"> >- <h2>Search targets <span style="display: inline; font-size: 70%; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span></h2> >+ <h2>Search targets</h2> > <div id="z3950_search_targets"> >+ <span style="display: inline; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> > [% FOREACH serverloo IN serverloop %] > <p> > [% IF ( serverloo.checked ) %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17487
:
56735
|
56736
|
56737
|
56738
| 56834 |
56835