Bugzilla – Attachment 56835 Details for
Bug 17487
Improper placement of select/clear all in Z39.50/SRU search dialog
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17487: Styling moved from style attribute into staff-global.css
Bug-17487-Styling-moved-from-style-attribute-into-.patch (text/plain), 4.89 KB, created by
Jonathan Druart
on 2016-10-25 08:33:28 UTC
(
hide
)
Description:
Bug 17487: Styling moved from style attribute into staff-global.css
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-10-25 08:33:28 UTC
Size:
4.89 KB
patch
obsolete
>From 31cf8782e516e92b8c4ab75ab174d26c9829e022 Mon Sep 17 00:00:00 2001 >From: radiuscz <radek.siman@centrum.cz> >Date: Mon, 24 Oct 2016 00:57:03 +0200 >Subject: [PATCH] Bug 17487: Styling moved from style attribute into > staff-global.css > >Test plan: >1) Apply patch >2) Display Z39.50 search dialogs: > - cataloguing / new from Z39.50 > - authorities / new from Z39.50 > - acquisition / new from an external source >3) Select all / Clear all should be placed below "Search targets" header >4) [Optionally] Set some style in IntranetUserCSS for class z3950checks > >https://bugs.koha-community.org/show_bug.cgi?id=17487 > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > koha-tmpl/intranet-tmpl/prog/css/staff-global.css | 4 ++++ > koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt | 2 +- > .../intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt | 2 +- > koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt | 2 +- > 4 files changed, 7 insertions(+), 3 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >index 52ee8d4..1caa186 100644 >--- a/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >+++ b/koha-tmpl/intranet-tmpl/prog/css/staff-global.css >@@ -803,6 +803,10 @@ fieldset.rows .inputnote { > overflow-y: auto; > } > >+.z3950checks { >+ padding-left: 1em; >+} >+ > .error { > color: #cc0000; > } >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >index 76f2356..f93a6df 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/z3950_search.tt >@@ -93,7 +93,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <div class="yui-u second"> > <h2>Search targets</h2> > <div id="z3950_search_targets_acq"> >- <span style="display: inline; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> >+ <span class="z3950checks"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> > [% FOREACH serverloo IN serverloop %] > <p> > [% IF ( serverloo.checked ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >index f75501c..a858b1e 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_auth_search.tt >@@ -92,7 +92,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <div class="yui-g"> > <h2>Search targets</h2> > <div id="z3950_search_targets_auth"> >- <span style="display: inline; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> >+ <span class="z3950checks"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> > [% FOREACH serverloo IN serverloop %] > <p> > [% IF ( serverloo.checked ) %] >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >index 0dcce14..b7b1ec9 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/z3950_search.tt >@@ -88,7 +88,7 @@ tr.selected { background-color : #FFFFCC; } tr.selected td { background-color : > <div class="yui-g"> > <h2>Search targets</h2> > <div id="z3950_search_targets"> >- <span style="display: inline; padding-left: 1em;"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> >+ <span class="z3950checks"><span class="checkall"><a id="CheckAll" href="#"><i class="fa fa-check"></i> Select all</a></span> | <span class="clearall"><a id="CheckNone" href="#"><i class="fa fa-remove"></i> Clear all</a></span></span> > [% FOREACH serverloo IN serverloop %] > <p> > [% IF ( serverloo.checked ) %] >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17487
:
56735
|
56736
|
56737
|
56738
|
56834
| 56835