Attachment 56847 Details for Bug 12359 – Bug 12359: Add HidePatronName functionality to the holds queue

[patch] Bug 12359: Add HidePatronName functionality to the holds queue

Bug-12359-Add-HidePatronName-functionality-to-the-.patch (text/plain), 3.10 KB, created by Chris Kirby on 2016-10-25 20:45:41 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Chris Kirby

Created: 2016-10-25 20:45:41 UTC

Size: 3.10 KB

patch

obsolete

>From 661bfd7caadb6ffe2aeb84977dc07351005316b9 Mon Sep 17 00:00:00 2001
>From: Katrin Fischer <Katrin.Fischer.83@web.de>
>Date: Mon, 10 Nov 2014 20:23:45 +0100
>Subject: [PATCH] Bug 12359: Add HidePatronName functionality to the holds
> queue
>
>This changes the Holds Queue page to not show the patron's name
>and phone number, but only the cardnumber, when HidePatronName
>is set to 'Don't show'
>
>This also changes the link to the patron account to use
>the borrowernumber instead of the cardnumber, which seems
>more consistent.
>
>Fixes a tiny capitalization error: Only item...
>
>To test:
>- Look at the holds queue page with holds displayed
>- Toggle HidePatronName system preference and observe the change
>- Make sure the link works correctly
>
>Signed-off-by: Katrin Fischer <katrin.fischer.83@web.de>
>Rebased 2016-10-16
>
>Signed-off-by: Chris Kirby <christopherlawrencekirby@gmail.com>
>---
> .../intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt | 12 ++++++++++--
> 1 file changed, 10 insertions(+), 2 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>index 67f3fc4..549b563 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/circ/view_holdsqueue.tt
>@@ -3,6 +3,7 @@
> [% USE Branches %]
> [% USE AuthorisedValues %]
> [% USE ColumnsSettings %]
>+[% USE Koha %]
> [% INCLUDE 'doc-head-open.inc' %]
> <title>Koha &rsaquo; Circulation &rsaquo; Holds queue</title>
> [% INCLUDE 'doc-head-close.inc' %]
>@@ -173,12 +174,19 @@ $(document).ready(function() {
> <td class="hq-enumchron">[% itemsloo.enumchron %]</td>
> <td class="hq-barcode">
> [% IF ( itemsloo.item_level_request ) %]
>-			Only Item: [% itemsloo.barcode %]
>+ Only item: [% itemsloo.barcode %]
> [% ELSE %]
> [% itemsloo.barcode %] or any available
> [% END %]
> </td>
>-			<td class="hq-patron"><a href="/cgi-bin/koha/circ/circulation.pl?findborrower=[% itemsloo.cardnumber %]#reserves">[% itemsloo.surname %], [% itemsloo.firstname %] ([% itemsloo.cardnumber %])</a> [% itemsloo.phone %]</td>
>+ <td class="hq-patron">
>+ [% IF Koha.Preference('HidePatronName') %]
>+ <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% itemsloo.borrowernumber %]#reserves">[% itemsloo.cardnumber %]</a>
>+ [% ELSE %]
>+ <a href="/cgi-bin/koha/circ/circulation.pl?borrowernumber=[% itemsloo.borrowernumber %]#reserves">[% itemsloo.surname %], [% itemsloo.firstname %] ([% itemsloo.cardnumber %])</a>
>+ [% itemsloo.phone %]
>+ [% END %]
>+ </td>
> <td class="hq-sendto">[% Branches.GetName( itemsloo.pickbranch ) %]</td>
> <td class="hq-date">[% itemsloo.reservedate | $KohaDates %]</td>
> <td class="hq-notes">[% itemsloo.notes %]</td>
>-- 
>1.9.1

Actions: View | Diff | Splinter Review

Attachments on bug 12359: 33439 | 56571 | 56847 | 57637