Bugzilla – Attachment 56850 Details for
Bug 17443
Make possible to renew patron by later of expiry and current date
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17443: Added tests
Bug-17443-Added-tests.patch (text/plain), 3.34 KB, created by
Jonathan Druart
on 2016-10-26 08:14:36 UTC
(
hide
)
Description:
Bug 17443: Added tests
Filename:
MIME Type:
Creator:
Jonathan Druart
Created:
2016-10-26 08:14:36 UTC
Size:
3.34 KB
patch
obsolete
>From 0ec24e6cb8ba4b4e329fbd81560089aa0167d5e4 Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Tue, 25 Oct 2016 18:27:53 +0000 >Subject: [PATCH] Bug 17443: Added tests > >Test plan: >prove t/db_dependent/Koha/Patrons.t > >Signed-off-by: Jonathan Druart <jonathan.druart@biblibre.com> >--- > t/db_dependent/Koha/Patrons.t | 35 ++++++++++++++++++++++++++++++++++- > 1 file changed, 34 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Koha/Patrons.t b/t/db_dependent/Koha/Patrons.t >index a699411..d9ac0a6 100644 >--- a/t/db_dependent/Koha/Patrons.t >+++ b/t/db_dependent/Koha/Patrons.t >@@ -166,10 +166,12 @@ subtest 'update_password' => sub { > }; > > subtest 'renew_account' => sub { >- plan tests => 6; >+ plan tests => 10; > my $a_month_ago = dt_from_string->add( months => -1 )->truncate( to => 'day' ); > my $a_year_later = dt_from_string->add( months => 12 )->truncate( to => 'day' ); > my $a_year_later_minus_a_month = dt_from_string->add( months => 11 )->truncate( to => 'day' ); >+ my $a_month_later = dt_from_string->add( months => 1 )->truncate( to => 'day' ); >+ my $a_year_later_plus_a_month = dt_from_string->add( months => 13 )->truncate( to => 'day' ); > my $patron_category = $builder->build( > { source => 'Category', > value => { >@@ -186,7 +188,25 @@ subtest 'renew_account' => sub { > } > } > ); >+ my $patron_2 = $builder->build( >+ { source => 'Borrower', >+ value => { >+ dateexpiry => $a_month_ago, >+ categorycode => $patron_category->{categorycode}, >+ } >+ } >+ ); >+ my $patron_3 = $builder->build( >+ { source => 'Borrower', >+ value => { >+ dateexpiry => $a_month_later, >+ categorycode => $patron_category->{categorycode}, >+ } >+ } >+ ); > my $retrieved_patron = Koha::Patrons->find( $patron->{borrowernumber} ); >+ my $retrieved_patron_2 = Koha::Patrons->find( $patron_2->{borrowernumber} ); >+ my $retrieved_patron_3 = Koha::Patrons->find( $patron_3->{borrowernumber} ); > > t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'dateexpiry' ); > t::lib::Mocks::mock_preference( 'BorrowersLog', 1 ); >@@ -206,7 +226,20 @@ subtest 'renew_account' => sub { > $number_of_logs = $schema->resultset('ActionLog')->search( { module => 'MEMBERS', action => 'RENEW', object => $retrieved_patron->borrowernumber } )->count; > is( $number_of_logs, 1, 'Without BorrowerLogs, Koha::Patron->renew_account should not have logged' ); > >+ t::lib::Mocks::mock_preference( 'BorrowerRenewalPeriodBase', 'combination' ); >+ $expiry_date = $retrieved_patron_2->renew_account; >+ is( $expiry_date, $a_year_later ); >+ $retrieved_expiry_date = Koha::Patrons->find( $patron_2->{borrowernumber} )->dateexpiry; >+ is( dt_from_string($retrieved_expiry_date), $a_year_later ); >+ >+ $expiry_date = $retrieved_patron_3->renew_account; >+ is( $expiry_date, $a_year_later_plus_a_month ); >+ $retrieved_expiry_date = Koha::Patrons->find( $patron_3->{borrowernumber} )->dateexpiry; >+ is( dt_from_string($retrieved_expiry_date), $a_year_later_plus_a_month ); >+ > $retrieved_patron->delete; >+ $retrieved_patron_2->delete; >+ $retrieved_patron_3->delete; > }; > > subtest "move_to_deleted" => sub { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17443
:
56443
|
56457
|
56845
|
56849
| 56850