Bugzilla – Attachment 56853 Details for
Bug 16588
Remove the Readonly dependency (again)
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Amended Patch
0001-Bug-16588-Remove-Readonly-from-Edifact-Order.patch (text/plain), 1.73 KB, created by
Colin Campbell
on 2016-10-26 09:59:22 UTC
(
hide
)
Description:
Amended Patch
Filename:
MIME Type:
Creator:
Colin Campbell
Created:
2016-10-26 09:59:22 UTC
Size:
1.73 KB
patch
obsolete
>From dbc58401b1ceacc37a44fd087d1165fc75c50105 Mon Sep 17 00:00:00 2001 >From: Colin Campbell <colin.campbell@ptfs-europe.com> >Date: Wed, 26 Oct 2016 10:43:18 +0100 >Subject: [PATCH] Bug 16588 Remove Readonly from Edifact::Order > >Remove Readonly dependency from Edifact::Order > >Do not replace with Constant as we want these variables to >interpolate and do not wish to change the logic in constructing the >service string advice >--- > Koha/Edifact/Order.pm | 19 +++++++++---------- > 1 file changed, 9 insertions(+), 10 deletions(-) > >diff --git a/Koha/Edifact/Order.pm b/Koha/Edifact/Order.pm >index 0381128..02a4dc4 100644 >--- a/Koha/Edifact/Order.pm >+++ b/Koha/Edifact/Order.pm >@@ -23,19 +23,18 @@ use utf8; > > use Carp; > use DateTime; >-use Readonly; > use Business::ISBN; > use Koha::Database; > use C4::Budgets qw( GetBudget ); > >-Readonly::Scalar my $seg_terminator => q{'}; >-Readonly::Scalar my $separator => q{+}; >-Readonly::Scalar my $component_separator => q{:}; >-Readonly::Scalar my $release_character => q{?}; >+my $seg_terminator = q{'}; >+my $separator = q{+}; >+my $component_separator = q{:}; >+my $release_character = q{?}; > >-Readonly::Scalar my $NINES_12 => 999_999_999_999; >-Readonly::Scalar my $NINES_14 => 99_999_999_999_999; >-Readonly::Scalar my $CHUNKSIZE => 35; >+my $NINES_12 = 999_999_999_999; >+my $NINES_14 = 99_999_999_999_999; >+my $CHUNKSIZE = 35; > > sub new { > my ( $class, $parameter_hashref ) = @_; >@@ -606,10 +605,10 @@ sub message_date_segment { > > sub _const { > my $key = shift; >- Readonly my %S => { >+ my %S = ( > service_string_advice => q{UNA:+.? '}, > message_identifier => q{+ORDERS:D:96A:UN:EAN008'}, >- }; >+ ); > return ( $S{$key} ) ? $S{$key} : q{}; > } > >-- >2.7.4 >
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 16588
:
53636
|
53637
|
53638
|
54477
|
55934
|
55935
|
55936
|
55937
|
56853
|
57516
|
57517
|
57518
|
57519
|
73444
|
73445
|
73446
|
73447
|
73448
|
73449
|
73450
|
73451
|
73452