Bugzilla – Attachment 56876 Details for
Bug 17495
reports/issues_stats.pl is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[PASSED QA] Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl
PASSED-QA-Bug-17495-Fix-method-selected-not-covere.patch (text/plain), 4.90 KB, created by
Katrin Fischer
on 2016-10-26 15:09:07 UTC
(
hide
)
Description:
[PASSED QA] Bug 17495: Fix 'method selected not covered by test' in reports/issues_stats.pl
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-10-26 15:09:07 UTC
Size:
4.90 KB
patch
obsolete
>From ac45bca5329ff7a133a24780eb4f7ff744592f01 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Tue, 25 Oct 2016 09:16:56 +0200 >Subject: [PATCH] [PASSED QA] Bug 17495: Fix 'method selected not covered by > test' in reports/issues_stats.pl >MIME-Version: 1.0 >Content-Type: text/plain; charset=UTF-8 >Content-Transfer-Encoding: 8bit > >If you access reports/issues_stats.pl, you will get >Template process failed: undef error - The method selected is not >covered by tests! at /home/vagrant/kohaclone/C4/Templates.pm line 121 >http://localhost:8081/cgi-bin/koha/reports/reports-home.pl > >Bug 15407 sent objects to the template and the selected method is not >defined. >The bug had been highlighted by bug 17425 which dies instead of hides the error. > >Not that the "selected" code was not needed, the different elements of >the page never select a specific value. > >Test plan: >Apply this patch and confirm that the error is no longuer displayed. > >Reproduced. Followed test plan, works as expected. >Signed-off-by: Marc Véron <veron@veron.ch> > >Signed-off-by: Katrin Fischer <katrin.fischer@bsz-bw.de> >--- > .../intranet-tmpl/prog/en/modules/reports/issues_stats.tt | 14 +++++++------- > 1 file changed, 7 insertions(+), 7 deletions(-) > >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >index c412ce8..f35324a 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/reports/issues_stats.tt >@@ -156,7 +156,7 @@ > <td><select name="Filter" id="borcat"> > <option value=""> </option> > [% FOREACH categoryloo IN categoryloop %] >- [% IF ( categoryloo.selected ) %]<option value="[% categoryloo.categorycode %]" selected="selected">[% categoryloo.description %]</option>[% ELSE %]<option value="[% categoryloo.categorycode %]">[% categoryloo.description %]</option>[% END %] >+ <option value="[% categoryloo.categorycode %]">[% categoryloo.description %]</option> > [% END %] > </select> > </td> >@@ -168,7 +168,7 @@ > <td><select name="Filter" id="itemtype"> > <option value=""> </option> > [% FOREACH itemtypeloo IN itemtypeloop %] >- [% IF ( itemtypeloo.selected ) %]<option value="[% itemtypeloo.code %]" selected="selected">[% itemtypeloo.description %]</option>[% ELSE %]<option value="[% itemtypeloo.code %]">[% itemtypeloo.description %]</option>[% END %] >+ <option value="[% itemtypeloo.code %]">[% itemtypeloo.description %]</option> > [% END %] > </select> > </td> >@@ -190,7 +190,7 @@ > <td><select name="Filter" id="ccode"> > <option value=""> </option> > [% FOREACH ccodeloo IN ccodeloop %] >- [% IF ( ccodeloo.selected ) %] <option value="[% ccodeloo.code %]" selected="selected">[% ccodeloo.description %]</option>[% ELSE %]<option value="[% ccodeloo.code %]">[% ccodeloo.description %]</option>[% END %] >+ <option value="[% ccodeloo.code %]">[% ccodeloo.description %]</option> > [% END %] > </select> > </td> >@@ -202,8 +202,8 @@ > <td><select name="Filter" id="location"> > <option value=""> </option> > [% FOREACH locationloo IN locationloop %] >- [% IF ( locationloo.selected ) %]<option value="[% locationloo.code %]" selected="selected">[% locationloo.description %]</option>[% ELSE %]<option value="[% locationloo.code %]">[% locationloo.description %]</option>[% END %] >- [% END %] >+ <option value="[% locationloo.code %]">[% locationloo.description %]</option> >+ [% END %] > </select> > </td> > </tr> >@@ -220,7 +220,7 @@ > <td><select name="Filter" id="sort1"> > <option value=""> </option> > [% FOREACH Bsort IN Bsort1 %] >- [% IF ( Bsort.selected ) %]<option value="[% Bsort.authorised_value %]" selected="selected">[% Bsort.lib %]</option>[% ELSE %]<option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option>[% END %] >+ <option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option> > [% END %] > </select> > </td> >@@ -233,7 +233,7 @@ > <td><select name="Filter" id="sort2"> > <option value=""> </option> > [% FOREACH Bsort IN Bsort2 %] >- [% IF ( Bsort.selected ) %]<option value="[% Bsort.authorised_value %]" selected="selected">[% Bsort.lib %]</option>[% ELSE %]<option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option>[% END %] >+ <option value="[% Bsort.authorised_value %]" >[% Bsort.lib %]</option> > [% END %] > </select> > </td> >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17495
:
56828
|
56866
| 56876