Bugzilla – Attachment 56878 Details for
Bug 7679
Add new filters to circulation statistics wizard
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 7679: Follow-up to fix group by hour
Bug-7679-Follow-up-to-fix-group-by-hour.patch (text/plain), 1.72 KB, created by
Katrin Fischer
on 2016-10-26 16:42:07 UTC
(
hide
)
Description:
Bug 7679: Follow-up to fix group by hour
Filename:
MIME Type:
Creator:
Katrin Fischer
Created:
2016-10-26 16:42:07 UTC
Size:
1.72 KB
patch
obsolete
>From ae055428d5d135971f2b762e1a4d385471bffefa Mon Sep 17 00:00:00 2001 >From: Katrin Fischer <katrin.fischer.83@web.de> >Date: Wed, 26 Oct 2016 18:31:06 +0200 >Subject: [PATCH] Bug 7679: Follow-up to fix group by hour > >Grouping by hour does not work with the collates. >This patch removes them after talking to Julian on IRC. > >This partially reverts one of the earlier patches: >Bug 7679: Display all table headers (case and accent > sensitive) > >One could argue that this is more of a data problem, >than something we should fix/'hide' with code. >--- > reports/issues_stats.pl | 5 ++--- > 1 file changed, 2 insertions(+), 3 deletions(-) > >diff --git a/reports/issues_stats.pl b/reports/issues_stats.pl >index 25d2278..5c7370e 100755 >--- a/reports/issues_stats.pl >+++ b/reports/issues_stats.pl >@@ -338,7 +338,7 @@ sub calculate { > $linefilter[0] =~ s/\*/%/g; > $strsth .= " AND $line LIKE ? "; > } >- $strsth .= " group by $linefield collate utf8_bin order by $lineorder "; >+ $strsth .= " group by $linefield order by $lineorder "; > $debug and warn $strsth; > push @loopfilter, { crit => 'SQL =', sql => 1, filter => $strsth }; > my $sth = $dbh->prepare($strsth); >@@ -427,7 +427,7 @@ sub calculate { > $strsth2 .= " AND $column LIKE ? " ; > } > >- $strsth2 .= " group by $colfield collate utf8_bin order by $colorder "; >+ $strsth2 .= " group by $colfield order by $colorder "; > $debug and warn $strsth2; > push @loopfilter, { crit => 'SQL =', sql => 1, filter => $strsth2 }; > my $sth2 = $dbh->prepare($strsth2); >@@ -556,7 +556,6 @@ sub calculate { > } else { > $strcalc .= " $colfield "; > } >- $strcalc .= " collate utf8_bin "; > > $strcalc .= " ORDER BY "; > if($line_attribute_type) { >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 7679
:
11479
|
13099
|
16242
|
16243
|
17798
|
22745
|
25053
|
25443
|
26531
|
31311
|
39250
|
39251
|
39252
|
39253
|
39254
|
39255
|
39256
|
39257
|
46184
|
46185
|
46186
|
46187
|
46188
|
46189
|
46190
|
46191
|
46192
|
46193
|
46194
|
46195
|
46196
|
46197
|
46198
|
46199
|
54598
|
54599
|
54600
|
54601
|
54602
|
54603
|
54604
|
54605
|
55481
|
55482
|
55483
|
55484
|
55485
|
55486
|
55487
|
55488
|
56877
|
56878
|
56879
|
56880
|
56881
|
56882
|
56883
|
56884
|
56885
|
56886
|
56887
|
56888