Bugzilla – Attachment 56953 Details for
Bug 14598
itemtype is not set on statistics by C4::Circulation::AddReturn
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14598: [QA Follow-up] Small changes
Bug-14598-QA-Follow-up-Small-changes.patch (text/plain), 2.07 KB, created by
Marcel de Rooy
on 2016-10-28 08:09:03 UTC
(
hide
)
Description:
Bug 14598: [QA Follow-up] Small changes
Filename:
MIME Type:
Creator:
Marcel de Rooy
Created:
2016-10-28 08:09:03 UTC
Size:
2.07 KB
patch
obsolete
>From 8d3ec22d59db286345bce78246a2a0269f011550 Mon Sep 17 00:00:00 2001 >From: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Date: Fri, 28 Oct 2016 09:54:20 +0200 >Subject: [PATCH] Bug 14598: [QA Follow-up] Small changes >Content-Type: text/plain; charset=utf-8 > >[1] Renames the dbrev version to XXX; adding a my for $sth, although > not strictly necessary it feels better. >[2] Circulation.t stumbles over: > Undefined subroutine &C4::Circulation::GetItem called at ... line 1283. > Somehow this is related to use_ok instead of a regular use. > Worked around this by require_ok and adding a regular use. > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >--- > installer/data/mysql/updatedatabase.pl | 4 ++-- > t/db_dependent/Circulation.t | 17 ++++++++++------- > 2 files changed, 12 insertions(+), 9 deletions(-) > >diff --git a/installer/data/mysql/updatedatabase.pl b/installer/data/mysql/updatedatabase.pl >index 5aadb15..0061183 100755 >--- a/installer/data/mysql/updatedatabase.pl >+++ b/installer/data/mysql/updatedatabase.pl >@@ -13344,10 +13344,10 @@ if ( CheckVersion($DBversion) ) { > SetVersion($DBversion); > } > >-$DBversion = "3.23.00.XXX"; >+$DBversion = "XXX"; > if ( CheckVersion($DBversion) ) { > >- $sth = $dbh->prepare(q{ >+ my $sth = $dbh->prepare(q{ > SELECT s.itemnumber, i.itype, b.itemtype > FROM > ( SELECT DISTINCT itemnumber >diff --git a/t/db_dependent/Circulation.t b/t/db_dependent/Circulation.t >index 18d1c87..8350ac0 100755 >--- a/t/db_dependent/Circulation.t >+++ b/t/db_dependent/Circulation.t >@@ -17,8 +17,18 @@ > > use Modern::Perl; > >+use Test::More tests => 88; >+ >+BEGIN { >+ require_ok('C4::Circulation'); >+} >+ > use DateTime; >+ > use t::lib::Mocks; >+use t::lib::TestBuilder; >+ >+use C4::Circulation; > use C4::Biblio; > use C4::Items; > use C4::Members; >@@ -27,13 +37,6 @@ use C4::Overdues qw(UpdateFine CalcFine); > use Koha::DateUtils; > use Koha::Database; > >-use t::lib::TestBuilder; >- >-use Test::More tests => 88; >- >-BEGIN { >- use_ok('C4::Circulation'); >-} > > my $schema = Koha::Database->schema; > $schema->storage->txn_begin; >-- >1.7.10.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14598
:
41198
|
41199
|
41200
|
41201
|
41202
|
41203
|
41204
|
41205
|
41383
|
41384
|
41385
|
41627
|
41628
|
41629
|
41637
|
42171
|
42177
|
44665
|
44666
|
44667
|
44668
|
45030
|
45047
|
45838
|
45843
|
45844
|
46546
|
46877
|
47108
|
47109
|
47110
|
47111
|
47112
|
47113
|
47114
|
47115
|
47116
|
49797
|
49798
|
49799
|
49800
|
49801
|
49802
|
49803
|
49804
|
49805
|
49807
|
49963
|
49964
|
49965
|
49966
|
49967
|
49968
|
49969
|
49970
|
49971
|
49972
|
49978
|
49979
|
49980
|
49981
|
49982
|
49983
|
49984
|
49985
|
49986
|
49987
|
49988
|
50018
|
56941
|
56942
|
56943
|
56944
|
56945
|
56946
|
56947
|
56948
|
56949
|
56950
|
56951
|
56952
| 56953 |
62539
|
62555
|
62682