Bugzilla – Attachment 57119 Details for
Bug 14957
Write protecting MARC fields based on source of import
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 14957: Followup - Pod, import_lexile.pl, template and test fixes
Bug-14957-Followup---Pod-importlexilepl-template-a.patch (text/plain), 3.45 KB, created by
Josef Moravec
on 2016-11-03 07:07:11 UTC
(
hide
)
Description:
Bug 14957: Followup - Pod, import_lexile.pl, template and test fixes
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2016-11-03 07:07:11 UTC
Size:
3.45 KB
patch
obsolete
>From b40fc5003710bf5828ef136022c3de248e28841c Mon Sep 17 00:00:00 2001 >From: Josef Moravec <josef.moravec@gmail.com> >Date: Wed, 19 Oct 2016 07:51:07 +0000 >Subject: [PATCH] Bug 14957: Followup - Pod, import_lexile.pl, template and > test fixes > >--- > C4/Biblio.pm | 2 +- > .../intranet-tmpl/prog/en/modules/admin/marc-permissions.tt | 2 +- > misc/migration_tools/import_lexile.pl | 3 ++- > t/db_dependent/Biblio/MARCPermissions.t | 10 +++------- > 4 files changed, 7 insertions(+), 10 deletions(-) > >diff --git a/C4/Biblio.pm b/C4/Biblio.pm >index 0c5649f..a441ab2 100644 >--- a/C4/Biblio.pm >+++ b/C4/Biblio.pm >@@ -304,7 +304,7 @@ sub AddBiblio { > > =head2 ModBiblio > >- ModBiblio( $record,$biblionumber,$frameworkcode); >+ ModBiblio( $record,$biblionumber,$frameworkcode,$filter ); > > Replace an existing bib record identified by C<$biblionumber> > with one supplied by the MARC::Record object C<$record>. The embedded >diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-permissions.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-permissions.tt >index b15bdf7..bed4188 100644 >--- a/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-permissions.tt >+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/admin/marc-permissions.tt >@@ -2,7 +2,7 @@ > [% INCLUDE 'doc-head-open.inc' %] > <title>Koha › Administration › MARC field permissions</title> > [% INCLUDE 'doc-head-close.inc' %] >-<link rel="stylesheet" type="text/css" href="[% themelang %]/css/datatables.css" /> >+<link rel="stylesheet" type="text/css" href="[% interface %]/[% theme %]/css/datatables.css" /> > [% INCLUDE 'datatables.inc' %] > > <style type="text/css"> >diff --git a/misc/migration_tools/import_lexile.pl b/misc/migration_tools/import_lexile.pl >index a261e53..3f89de4 100755 >--- a/misc/migration_tools/import_lexile.pl >+++ b/misc/migration_tools/import_lexile.pl >@@ -151,6 +151,7 @@ while ( my $row = $csv->getline_hr($fh) ) { > foreach my $biblionumber (@biblionumbers) { > $counter++; > my $record = GetMarcBiblio($biblionumber); >+ my $frameworkcode = GetFrameworkCode($biblionumber); > > if ($verbose) { > say "Found matching record! Biblionumber: $biblionumber"; >@@ -200,7 +201,7 @@ while ( my $row = $csv->getline_hr($fh) ) { > $record->append_fields($field); > } > >- ModBiblio( $record, $biblionumber, {source => 'import_lexile'} ) unless ( $test ); >+ ModBiblio( $record, $biblionumber, $frameworkcode, {source => 'import_lexile'} ) unless ( $test ); > } > > } >diff --git a/t/db_dependent/Biblio/MARCPermissions.t b/t/db_dependent/Biblio/MARCPermissions.t >index cf2e2c6..d942680 100755 >--- a/t/db_dependent/Biblio/MARCPermissions.t >+++ b/t/db_dependent/Biblio/MARCPermissions.t >@@ -32,13 +32,9 @@ my $dbh = C4::Context->dbh; > $dbh->{AutoCommit} = 0; > $dbh->{RaiseError} = 1; > >-# Undef C4::Biblio::inverted_field_map to avoid problems introduced >-# by caching in TransformMarcToKoha >-undef $C4::Biblio::inverted_field_map; >- >-C4::Context->set_preference( "MARCPermissions", 1); >-C4::Context->set_preference( "MARCPermissionsLog", 1); >-C4::Context->set_preference( "MARCPermissionsCorrectionSimilarity", 90); >+C4::Context->set_preference( 'MARCPermissions', '1'); >+C4::Context->set_preference( 'MARCPermissionsLog', '1'); >+C4::Context->set_preference( 'MARCPermissionsCorrectionSimilarity', '90'); > > # Create a record > my $record = MARC::Record->new(); >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 14957
:
44056
|
44057
|
44058
|
51723
|
51724
|
56637
|
56638
|
56643
|
56644
|
56645
|
56646
|
56647
|
56648
|
57114
|
57115
|
57116
|
57117
|
57118
|
57119
|
59811
|
59812
|
59885
|
60711
|
60824
|
60825
|
61065
|
61641
|
61736
|
64792
|
72498
|
74855
|
75118
|
76201
|
76202
|
76203
|
76204
|
76205
|
76206
|
76207
|
76208
|
76209
|
76210
|
78651
|
78652
|
78653
|
79367
|
79368
|
79369
|
79370
|
79890
|
80972
|
80973
|
80974
|
80975
|
81176
|
81177
|
81178
|
81179
|
81621
|
81699
|
81700
|
81705
|
81706
|
81707
|
81708
|
81969
|
81970
|
81971
|
82030
|
82031
|
82775
|
87709
|
87711
|
87771
|
87929
|
88205
|
88206
|
89961
|
90668
|
90669
|
90671
|
90672
|
90722
|
90723
|
90740
|
90741
|
92933
|
92934
|
92935
|
92936
|
92937
|
92938
|
92999
|
93499
|
94909
|
94911
|
99998
|
100052
|
100053
|
100054
|
100055
|
100056
|
100057
|
100058
|
100059
|
100060
|
100061
|
101510
|
109955
|
109956
|
109957
|
109958
|
109959
|
109960
|
109961
|
109962
|
109963
|
116622
|
116623
|
116624
|
116625
|
117844
|
117845
|
117849
|
117850
|
117853
|
117859
|
117964
|
117965
|
117966
|
118918
|
118919
|
118920
|
118921
|
118922
|
118923
|
118924
|
118925
|
118926
|
118927
|
118934
|
118935
|
118936
|
118937
|
118938
|
118939
|
118940
|
118941
|
118942
|
118943
|
118944
|
118945
|
118946
|
118957
|
120533
|
120534
|
120535
|
120536
|
120537
|
120538
|
120539
|
120540
|
120541
|
120542
|
120543
|
120544
|
120545
|
120546
|
120547
|
120548
|
120550
|
120553
|
120554
|
120555
|
120556
|
120557
|
120581
|
120582
|
120583
|
120584
|
120585
|
120586
|
120587
|
120588
|
120589
|
120590
|
120591
|
120592
|
120593
|
120594
|
120595
|
120596
|
120597
|
120598
|
120599
|
120600
|
120601
|
120602
|
120603
|
120604
|
120605
|
120670
|
120671
|
120705
|
125514
|
125515
|
125516
|
125517
|
125518
|
125519
|
125520
|
125521
|
125522
|
125523
|
125524
|
125525
|
125526
|
125527
|
125528
|
125529
|
125530
|
125531
|
125532
|
125533
|
125534
|
125535
|
125536
|
125537
|
125538
|
125539
|
125540
|
125632
|
125633
|
125636
|
126424
|
126425
|
126431
|
126592
|
126666
|
126667
|
126752
|
126753
|
126754
|
126755
|
126756
|
126757
|
126758
|
126759
|
126760
|
126761
|
126762
|
126763
|
126764
|
126765
|
126766
|
126767
|
126768
|
126769
|
126770
|
126771
|
126772
|
126773
|
126774
|
126775
|
126776
|
126777
|
126778
|
126779
|
126780
|
126781
|
126782
|
126783
|
126784
|
126785
|
126786
|
126950
|
126951