Bugzilla – Attachment 57133 Details for
Bug 17538
t/db_dependent/Upload.t is broken
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t
Bug-17538-Bug-17216-follow-up-Fix-tdbdependentUplo.patch (text/plain), 1.46 KB, created by
Tomás Cohen Arazi (tcohen)
on 2016-11-03 14:39:42 UTC
(
hide
)
Description:
Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t
Filename:
MIME Type:
Creator:
Tomás Cohen Arazi (tcohen)
Created:
2016-11-03 14:39:42 UTC
Size:
1.46 KB
patch
obsolete
>From 65bebb1c07c823e5611078b4d784f50bfe00a333 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Wed, 2 Nov 2016 11:01:54 +0000 >Subject: [PATCH] Bug 17538: (Bug 17216 follow-up) Fix t/db_dependent/Upload.t > >The insert into authorised_values failed because of the missing FK > >Test plan: > prove t/db_dependent/Upload.t >should return green > >Signed-off-by: Marcel de Rooy <m.de.rooy@rijksmuseum.nl> >Signed-off-by: Tomas Cohen Arazi <tomascohen@theke.io> >--- > t/db_dependent/Upload.t | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > >diff --git a/t/db_dependent/Upload.t b/t/db_dependent/Upload.t >index 1449c98..20791f3 100644 >--- a/t/db_dependent/Upload.t >+++ b/t/db_dependent/Upload.t >@@ -161,7 +161,8 @@ sub test06 { #some extra tests for get > sub test07 { #simple test for httpheaders and getCategories > my @hdrs = Koha::Upload->httpheaders('does_not_matter_yet'); > is( @hdrs == 4 && $hdrs[1] =~ /application\/octet-stream/, 1, 'Simple test for httpheaders'); >- $dbh->do("INSERT INTO authorised_values (category, authorised_value, lib) VALUES (?,?,?) ", undef, ( 'UPLOAD', 'HAVE_AT_LEAST_ONE', 'Hi there' )); >+ my $builder = t::lib::TestBuilder->new; >+ $builder->build({ source => 'AuthorisedValue', value => { category => 'UPLOAD', authorised_value => 'HAVE_AT_LEAST_ONE', lib => 'Hi there' } }); > my $cat = Koha::Upload->getCategories; > is( @$cat >= 1, 1, 'getCategories returned at least one category' ); > } >-- >2.7.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17538
:
57077
|
57097
| 57133