Bugzilla – Attachment 57167 Details for
Bug 17548
Step 1 of memberentry explodes
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
[SIGNED-OFF] Bug 17548: Fix step 1 of memberentry
SIGNED-OFF-Bug-17548-Fix-step-1-of-memberentry.patch (text/plain), 1.50 KB, created by
Josef Moravec
on 2016-11-04 09:42:26 UTC
(
hide
)
Description:
[SIGNED-OFF] Bug 17548: Fix step 1 of memberentry
Filename:
MIME Type:
Creator:
Josef Moravec
Created:
2016-11-04 09:42:26 UTC
Size:
1.50 KB
patch
obsolete
>From 8e5961417b6ce9da8614f9fa6c64f220cf01e1a0 Mon Sep 17 00:00:00 2001 >From: Jonathan Druart <jonathan.druart@bugs.koha-community.org> >Date: Fri, 4 Nov 2016 09:19:01 +0000 >Subject: [PATCH] [SIGNED-OFF] Bug 17548: Fix step 1 of memberentry > >This bug has been highlighted by bug 15407. > >The date limit check on the category code did not work on step 1. But >after bug 15407 the script crashes with > Can't call method "dateofbirthrequired" on an undefined value at > /home/vagrant/kohaclone/members/memberentry.pl line 311. > >Test plan: >- Edit "step 1" information of a patron (first 'Edit' on a patron detail >page). >- Save >=> Without this patch it BOOMs >=> With this patch, the info should be correctly saved > >Signed-off-by: Josef Moravec <josef.moravec@gmail.com> >--- > members/memberentry.pl | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/members/memberentry.pl b/members/memberentry.pl >index d2f462f..95d2af0 100755 >--- a/members/memberentry.pl >+++ b/members/memberentry.pl >@@ -307,7 +307,7 @@ if ($op eq 'save' || $op eq 'insert'){ > > if ( $newdata{dateofbirth} ) { > my $age = GetAge($newdata{dateofbirth}); >- my $borrowercategory = Koha::Patron::Categories->find($newdata{categorycode}); >+ my $borrowercategory = Koha::Patron::Categories->find($categorycode); > my ($low,$high) = ($borrowercategory->dateofbirthrequired, $borrowercategory->upperagelimit); > if (($high && ($age > $high)) or ($age < $low)) { > push @errors, 'ERROR_age_limitations'; >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 17548
:
57158
|
57167
|
57227