Bugzilla – Attachment 57194 Details for
Bug 15907
Remove use of makepayment in opac/opac-account-pay-paypal-return.pl
Home
|
New
|
Browse
|
Search
|
[?]
|
Reports
|
Help
|
New Account
|
Log In
[x]
|
Forgot Password
Login:
[x]
[patch]
Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl
Bug-15907---Remove-use-of-makepayment-in-opacopac-.patch (text/plain), 1.58 KB, created by
Kyle M Hall (khall)
on 2016-11-04 13:32:50 UTC
(
hide
)
Description:
Bug 15907 - Remove use of makepayment in opac/opac-account-pay-paypal-return.pl
Filename:
MIME Type:
Creator:
Kyle M Hall (khall)
Created:
2016-11-04 13:32:50 UTC
Size:
1.58 KB
patch
obsolete
>From 1a9bf1b7fe8c1230f0936fe653db9c6953ca9090 Mon Sep 17 00:00:00 2001 >From: Kyle M Hall <kyle@bywatersolutions.com> >Date: Wed, 24 Feb 2016 15:56:52 +0000 >Subject: [PATCH] Bug 15907 - Remove use of makepayment in > opac/opac-account-pay-paypal-return.pl > >Test Plan: >1) Apply this patch >2) Make a payment via PayPal in sandbox mode >3) Note the payment succeeds >--- > opac/opac-account-pay-paypal-return.pl | 14 ++++++++++---- > 1 file changed, 10 insertions(+), 4 deletions(-) > >diff --git a/opac/opac-account-pay-paypal-return.pl b/opac/opac-account-pay-paypal-return.pl >index 742f5ae..96417bd 100755 >--- a/opac/opac-account-pay-paypal-return.pl >+++ b/opac/opac-account-pay-paypal-return.pl >@@ -93,10 +93,16 @@ if ( $response->is_success ) { > if ( $params{ACK} eq "Success" ) { > $amount = $params{PAYMENTINFO_0_AMT}; > >- my $accountlines_rs = Koha::Database->new()->schema()->resultset('Accountline'); >- foreach my $accountlines_id ( @accountlines ) { >- my $accountline = $accountlines_rs->find( $accountlines_id ); >- makepayment( $accountlines_id, $borrowernumber, undef, $accountline->amountoutstanding, undef, undef, 'PayPal' ); >+ my $account = Koha::Account->new( { patron_id => $borrowernumber } ); >+ foreach my $accountlines_id (@accountlines) { >+ my $line = Koha::Account::Lines->find($accountlines_id); >+ $account->pay( >+ { >+ amount => $amount, >+ lines => [$line], >+ note => 'PayPal' >+ } >+ ); > } > } > else { >-- >2.1.4
You cannot view the attachment while viewing its details because your browser does not support IFRAMEs.
View the attachment on a separate page
.
View Attachment As Diff
View Attachment As Raw
Actions:
View
|
Diff
|
Splinter Review
Attachments on
bug 15907
:
48348
|
52149
|
57194
|
58816
|
58829
|
58830
|
58840