Attachment 57226 Details for Bug 11274 – Bug 11274: Sent Notices Tab Not Working Correctl

[patch] Bug 11274: Sent Notices Tab Not Working Correctl

Bug-11274-Sent-Notices-Tab-Not-Working-Correctl.patch (text/plain), 1.63 KB, created by Josef Moravec on 2016-11-06 08:53:00 UTC

(hide)

Description:

Filename:

MIME Type:

Creator: Josef Moravec

Created: 2016-11-06 08:53:00 UTC

Size: 1.63 KB

patch

obsolete

>From c4897e254a4a3b0f18afc4d277e78552904966dc Mon Sep 17 00:00:00 2001
>From: Josef Moravec <josef.moravec@gmail.com>
>Date: Thu, 3 Nov 2016 11:33:51 +0000
>Subject: [PATCH] Bug 11274: Sent Notices Tab Not Working Correctl
>
>Test plan
>1) have a patron with more then 20 notices sent
>2) go to patron profile -> notices
>-> without patch, the showing/hidding of notices content does work
>correctly only on first loaded page
>-> with patch, it should work correctly everywhere - try to use
>paginator, searching, ordering....
>---
> .../intranet-tmpl/prog/en/modules/members/notices.tt      | 15 ++++++++++-----
> 1 file changed, 10 insertions(+), 5 deletions(-)
>
>diff --git a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>index 662a72e..c6de80d 100644
>--- a/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/members/notices.tt
>@@ -16,17 +16,22 @@
>         "sPaginationType": "four_button"
>     }));
> 
>-    $(".notice").hide();
>-    $(".notice-title").click(function(e){
>+    var noticelistener = function(e) {
>         $(this).closest("tr").children().children(".notice").toggle();
>-        e.preventDefault();
>+        e.stopPropagation();
>+    };
>+
>+    $(".notice-title").click(noticelistener);
>+
>+    $("#noticestable").on("draw.dt page.dt search.dt order.dt", function(e) {
>+        $(".notice-title").click(noticelistener);
>     });
>-    
>+
>     });
> //]]>
> </script>
> <style type="text/css">
>-    p.notice { display: none; }
>+    div.notice { display: none; }
>     a.notice-title { font-weight: bold; display: block; }
> </style>
> </head>
>-- 
>2.1.4

Actions: View | Diff | Splinter Review

Attachments on bug 11274: 57226 | 57673 | 57679 | 57854 | 58114